[xoreos-git] [xoreos/phaethon] e50ad1: COMMON: Don't negate a negative composeString() va...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/phaethon
  Commit: e50ad1effc36061a81649f2581fe07473c314a93
      https://github.com/xoreos/phaethon/commit/e50ad1effc36061a81649f2581fe07473c314a93
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Don't negate a negative composeString() value

This will fail for INT*_MIN, because -INT*_MIN are not valid values.

Because the sign of the result of % on negative values might be
implementation defined, we also need to ABS it, then.


  Commit: f95d115812ba212a0efb8b904f233584d2256a1e
      https://github.com/xoreos/phaethon/commit/f95d115812ba212a0efb8b904f233584d2256a1e
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Rewrite composeString() to fill from back to front

This way, we don't need to reverse the string.


  Commit: 2794615a7973697e4ff7f461041cab590c3775ab
      https://github.com/xoreos/phaethon/commit/2794615a7973697e4ff7f461041cab590c3775ab
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/types.h

  Log Message:
  -----------
  COMMON: Also add fallback macros for INT*_MIN and INT*_MAX


Compare: https://github.com/xoreos/phaethon/compare/476c4a6732c3...2794615a7973