[xoreos-git] [xoreos/xoreos-tools] 34ef0d: COMMON: Don't negate a negative composeString() va...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos-tools
  Commit: 34ef0dc110661ae6aaee1faa7efc7447a953bf68
      https://github.com/xoreos/xoreos-tools/commit/34ef0dc110661ae6aaee1faa7efc7447a953bf68
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Don't negate a negative composeString() value

This will fail for INT*_MIN, because -INT*_MIN are not valid values.

Because the sign of the result of % on negative values might be
implementation defined, we also need to ABS it, then.


  Commit: bcb5cae8fd4847b126d337fda3a131cae85adba3
      https://github.com/xoreos/xoreos-tools/commit/bcb5cae8fd4847b126d337fda3a131cae85adba3
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Rewrite composeString() to fill from back to front

This way, we don't need to reverse the string.


  Commit: 4c2098445770c7d72b5d2b8147ed98aee6f9bc61
      https://github.com/xoreos/xoreos-tools/commit/4c2098445770c7d72b5d2b8147ed98aee6f9bc61
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/types.h

  Log Message:
  -----------
  COMMON: Also add fallback macros for INT*_MIN and INT*_MAX


Compare: https://github.com/xoreos/xoreos-tools/compare/0ee06754b301...4c2098445770