[xoreos-git] [xoreos/xoreos] cf6d8c: COMMON: Don't negate a negative composeString() va...

GitHub noreply at github.com
Mon Nov 21 00:22:54 CET 2016


  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: cf6d8c89c6d88fb4f7cfa113cafdd0cb89cec216
      https://github.com/xoreos/xoreos/commit/cf6d8c89c6d88fb4f7cfa113cafdd0cb89cec216
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Don't negate a negative composeString() value

This will fail for INT*_MIN, because -INT*_MIN are not valid values.

Because the sign of the result of % on negative values might be
implementation defined, we also need to ABS it, then.


  Commit: 81122d28856bcdd07c1c1b7420815befe64ea007
      https://github.com/xoreos/xoreos/commit/81122d28856bcdd07c1c1b7420815befe64ea007
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Rewrite composeString() to fill from back to front

This way, we don't need to reverse the string.


  Commit: 4ba33e4990ec96ad2424e505db5ab5a4b3974218
      https://github.com/xoreos/xoreos/commit/4ba33e4990ec96ad2424e505db5ab5a4b3974218
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2016-11-21 (Mon, 21 Nov 2016)

  Changed paths:
    M src/common/types.h

  Log Message:
  -----------
  COMMON: Also add fallback macros for INT*_MIN and INT*_MAX


Compare: https://github.com/xoreos/xoreos/compare/e1b67748a177...4ba33e4990ec


More information about the xoreos-git mailing list