[xoreos-git] [xoreos/xoreos] 31d2f6: COMMON: Document the XMLParser constructor paramet...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: 31d2f644aabe0fa5b65ecfe1d03c00bc6f1247de
      https://github.com/xoreos/xoreos/commit/31d2f644aabe0fa5b65ecfe1d03c00bc6f1247de
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/common/xml.h

  Log Message:
  -----------
  COMMON: Document the XMLParser constructor parameters


  Commit: 47b1a78bf6d04246bdbdde0fe04de9c9d3b26bc4
      https://github.com/xoreos/xoreos/commit/47b1a78bf6d04246bdbdde0fe04de9c9d3b26bc4
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/common/xml.cpp

  Log Message:
  -----------
  COMMON: Plug a leak when trying to parse broken XML files

We previously gave libxml2 an error reporting function that throws.
This of course means that libxml2 can't correctly deallocate parsing
contexts that fail.

Moreover, libxml2 wants to call this function multiple times to build
up its error string. This also doesn't fit with a throwing function.

Instead, we now give libxml2 an error reporting function that builds
up an UString, which we can then, after parsing has failed put into an
exception and throw.


  Commit: 89dc0c02c7ee2417e027aed9cf9465157373796f
      https://github.com/xoreos/xoreos/commit/89dc0c02c7ee2417e027aed9cf9465157373796f
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/common/xml.cpp
    M src/common/xml.h

  Log Message:
  -----------
  COMMON: Add a parameter fileName, for error reporting, to XMLParser


  Commit: 131e2a5412b4b6d5e3437255571c89ceb3b789a4
      https://github.com/xoreos/xoreos/commit/131e2a5412b4b6d5e3437255571c89ceb3b789a4
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/engines/dragonage/campaign.cpp

  Log Message:
  -----------
  DRAGONAGE: Give the campaign manifest path to the XMLParser

For more intuitive error reporting.


  Commit: 2d9f9013890baba965178bd8f68eacb05c9d13ec
      https://github.com/xoreos/xoreos/commit/2d9f9013890baba965178bd8f68eacb05c9d13ec
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/engines/dragonage2/campaign.cpp

  Log Message:
  -----------
  DRAGONAGE2: Give the campaign manifest path to the XMLParser

For more intuitive error reporting.


  Commit: 08605392c5d8dd38f537465a802c0717f2a5dbfc
      https://github.com/xoreos/xoreos/commit/08605392c5d8dd38f537465a802c0717f2a5dbfc
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/graphics/aurora/model_dragonage.cpp
    M src/graphics/aurora/model_dragonage.h

  Log Message:
  -----------
  GRAPHICS: Give the MAO file name to the XMLParser

For more intuitive error reporting.


Compare: https://github.com/xoreos/xoreos/compare/8ab6e9f18372...08605392c5d8
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.