[xoreos-git] [xoreos/xoreos-tools] 8cbff3: TESTS: Add a test for our XMLParser

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos-tools
  Commit: 8cbff3e6ba3adb20532a0826f1c37402d6f0578c
      https://github.com/xoreos/xoreos-tools/commit/8cbff3e6ba3adb20532a0826f1c37402d6f0578c
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M .gitignore
    M tests/rules.mk
    A tests/xml/rules.mk
    A tests/xml/xmlparser.cpp

  Log Message:
  -----------
  TESTS: Add a test for our XMLParser

Copied from xoreos proper.


  Commit: 7e4ed34135087cd9d1942a537637a87ca2d69f30
      https://github.com/xoreos/xoreos-tools/commit/7e4ed34135087cd9d1942a537637a87ca2d69f30
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/xml/xmlparser.h

  Log Message:
  -----------
  XML: Document the XMLParser constructor parameters


  Commit: a4ca4096acb28427c14d6e12b07531294b28b047
      https://github.com/xoreos/xoreos-tools/commit/a4ca4096acb28427c14d6e12b07531294b28b047
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/xml/xmlparser.cpp

  Log Message:
  -----------
  XML: Plug a leak when trying to parse broken XML files

We previously gave libxml2 an error reporting function that throws.
This of course means that libxml2 can't correctly deallocate parsing
contexts that fail.

Moreover, libxml2 wants to call this function multiple times to build
up its error string. This also doesn't fit with a throwing function.

Instead, we now give libxml2 an error reporting function that builds
up an UString, which we can then, after parsing has failed put into an
exception and throw.


  Commit: 06b356e5466bdbc3623b7ca4ecb6b2ff239a64a5
      https://github.com/xoreos/xoreos-tools/commit/06b356e5466bdbc3623b7ca4ecb6b2ff239a64a5
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/xml/xmlparser.cpp
    M src/xml/xmlparser.h

  Log Message:
  -----------
  XML: Add a parameter fileName, for error reporting, to XMLParser


  Commit: 215bfa4683629594b6218825140b97f1fee85d20
      https://github.com/xoreos/xoreos-tools/commit/215bfa4683629594b6218825140b97f1fee85d20
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/xml/ssfcreator.cpp
    M src/xml/ssfcreator.h
    M src/xml2ssf.cpp

  Log Message:
  -----------
  XML2SSF: Give the input file name to the XMLParser

For more intuitive error reporting.


  Commit: 9c236adb2f67f048dac017b392195d80d65940aa
      https://github.com/xoreos/xoreos-tools/commit/9c236adb2f67f048dac017b392195d80d65940aa
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-15 (Fri, 15 Jun 2018)

  Changed paths:
    M src/xml/tlkcreator.cpp
    M src/xml/tlkcreator.h
    M src/xml2tlk.cpp

  Log Message:
  -----------
  XML2TLK: Give the input file name to the XMLParser

For more intuitive error reporting.


Compare: https://github.com/xoreos/xoreos-tools/compare/06e8c82fd56c...9c236adb2f67
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.