[xoreos-git] [xoreos/xoreos] 2578aa: TRAVIS: Try suppressing warnings in system includes

Sven Hesse noreply at github.com
Wed Aug 26 23:56:47 CEST 2020


  Branch: refs/heads/traviswarnings
  Home:   https://github.com/xoreos/xoreos
  Commit: 2578aac279bda1901312e4c04829496994ecda71
      https://github.com/xoreos/xoreos/commit/2578aac279bda1901312e4c04829496994ecda71
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2020-08-26 (Wed, 26 Aug 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  TRAVIS: Try suppressing warnings in system includes

For two reasons, SDL2 when compiling with Clang and Boost.Locale on
macOS.

Clang ignores the "/* fallthrough */" comments in the SDL2 includes
and then complains about unmarked switch-case-fallthroughs. The SDL2
search script doesn't mark the SDL2 directory as system.

The Travis CI macOS build VMs have Boost.Locale preinstalled in
/usr/local/ and this is not marked as a system include. The version
preinstalled used std::auto_ptr and Clang notes that this is
deprecated.


  Commit: b547d3a23085920ad3e50aab86a7b0bcdb138b26
      https://github.com/xoreos/xoreos/commit/b547d3a23085920ad3e50aab86a7b0bcdb138b26
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2020-08-26 (Wed, 26 Aug 2020)

  Changed paths:
    M CMakeLists.txt
    M configure.ac

  Log Message:
  -----------
  BUILD: Disable -Wunused-const-variable

This one is enabled by -Wall in Clang, but not in gcc (at least not
for C++). The warning doesn't make sense for us, especially since we
sometimes leave in unused static const values for documentation
purposes, so let's disable it.


  Commit: 0cf8aca343f1df219a9fd9d62573055c48970b67
      https://github.com/xoreos/xoreos/commit/0cf8aca343f1df219a9fd9d62573055c48970b67
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2020-08-26 (Wed, 26 Aug 2020)

  Changed paths:
    M CMakeLists.txt
    M configure.ac

  Log Message:
  -----------
  BUILD: Disable -Wtautological-unsigned-enum-zero-compare

Whether an enum is signed or unsigned is implementation defined, so
this warning doesn't make any sense for us.


  Commit: f189c091c1b7e36aa6f79ea6211bd9eb43e7a357
      https://github.com/xoreos/xoreos/commit/f189c091c1b7e36aa6f79ea6211bd9eb43e7a357
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2020-08-26 (Wed, 26 Aug 2020)

  Changed paths:
    M src/graphics/icon.cpp

  Log Message:
  -----------
  GRAPHICS: Silence unused parameter/function warnings on macOS


Compare: https://github.com/xoreos/xoreos/compare/d191086711b3...f189c091c1b7



More information about the xoreos-git mailing list