[xoreos-git] [xoreos/xoreos] 9a608b: GRAPHICS: Use std::numeric_limits over literals

Luis Cáceres noreply at github.com
Tue Aug 25 23:22:58 CEST 2020


  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: 9a608b37d5dae6d0a3b081c8acb5c7430c6504e7
      https://github.com/xoreos/xoreos/commit/9a608b37d5dae6d0a3b081c8acb5c7430c6504e7
  Author: mirv <mirv.sillyfish at gmail.com>
  Date:   2020-08-25 (Tue, 25 Aug 2020)

  Changed paths:
    M src/graphics/shader/shadermaterial.cpp
    M src/graphics/shader/shadersurface.cpp

  Log Message:
  -----------
  GRAPHICS: Use std::numeric_limits over literals

Use std::numerics_limits<type>::max() to indicate invalid index
values rather than the more error prone literals of 0xFFFFFFFF.


  Commit: b347a6514bfe1c65d86778b7f27478f620b0e601
      https://github.com/xoreos/xoreos/commit/b347a6514bfe1c65d86778b7f27478f620b0e601
  Author: Luis Cáceres <lacaceres97 at gmail.com>
  Date:   2020-08-25 (Tue, 25 Aug 2020)

  Changed paths:
    M src/engines/kotorbase/game.h

  Log Message:
  -----------
  KOTORBASE: Fix ODR violation

GCC 10.2 reports an ODR warning due to a mismatch in type
Engines::KotORBase::Game. Specifically, the type ambiguity of the
`_console` member means in some source files it gets resolved as
Engines::Console and sometimes as Engines::KotORBase::Console.

This fixes the ambiguity.


Compare: https://github.com/xoreos/xoreos/compare/ab0587d68521...b347a6514bfe



More information about the xoreos-git mailing list