[xoreos-git] [xoreos/xoreos] 35fd07: NWN2: ItemProperty class needs to have an invalid ...

[mirv-sillyfish]

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: 35fd072d5468f5ccbc6bbf26adc59f361995397e
      https://github.com/xoreos/xoreos/commit/35fd072d5468f5ccbc6bbf26adc59f361995397e
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-03-24 (Sun, 24 Mar 2019)

  Changed paths:
    M src/engines/nwn2/itemproperty.cpp
    M src/engines/nwn2/script/functions_inventory.cpp
    M src/engines/nwn2/script/functions_itemproperty.cpp
    M src/engines/nwn2/types.h

  Log Message:
  -----------
  NWN2: ItemProperty class needs to have an invalid mode

Testing of ItemProperty calls in the game engine showed that the
parameter functions return '-1' for an invalid property. An invalid
item property type has been added to enable this behavior. If a
parameter is set to the max for its type, this will also cause a
'-1' to be returned.


  Commit: ea12d5927fdf29628e1ef7c67b0f2f3a5c2270ff
      https://github.com/xoreos/xoreos/commit/ea12d5927fdf29628e1ef7c67b0f2f3a5c2270ff
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-03-24 (Sun, 24 Mar 2019)

  Changed paths:
    M src/engines/nwn2/script/function_tables.h
    M src/engines/nwn2/script/functions.h
    M src/engines/nwn2/script/functions_itemproperty.cpp
    M src/engines/nwn2/types.h

  Log Message:
  -----------
  NWN2: Implement ItemProperty creation functions


  Commit: 40035ba53ecc52df2d5c20740a26d66c40750d20
      https://github.com/xoreos/xoreos/commit/40035ba53ecc52df2d5c20740a26d66c40750d20
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-03-24 (Sun, 24 Mar 2019)

  Changed paths:
    M src/engines/nwn2/door.cpp
    M src/engines/nwn2/module.cpp
    M src/engines/nwn2/module.h
    M src/engines/nwn2/trap.cpp
    A tests/engines/nwn2/door.cpp
    A tests/engines/nwn2/door.h
    M tests/engines/nwn2/rules.mk

  Log Message:
  -----------
  NWN2: Add unit test for NWN2 doors

For some reason the door 'isOpen()' call is returning true even
though the "AnimationState" parameter is set to zero for all four
doors. A cursory check of the code didn't turn up a reason, so for
now I left that test disabled.


  Commit: f72310e208ba153ecd717f81acc5772de6cfa8f8
      https://github.com/xoreos/xoreos/commit/f72310e208ba153ecd717f81acc5772de6cfa8f8
  Author: mirv <mirv.sillyfish at gmail.com>
  Date:   2019-03-24 (Sun, 24 Mar 2019)

  Changed paths:
    M src/graphics/graphics.cpp
    M src/graphics/graphics.h

  Log Message:
  -----------
  GRAPHICS: Project using perspective matrix

When performing a project operation, use _perspective matrix
explicitly.


Compare: https://github.com/xoreos/xoreos/compare/edb4d001d65b...f72310e208ba