[xoreos-git] [xoreos/xoreos] 29475e: COMMON: Guard against UTF-8 exceptions in stricmp too

Sat Mar 2 15:16:57 CET 2019

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/xoreos
  Commit: 29475eb58f0a76074b8b992b3013d96689fc228e
      https://github.com/xoreos/xoreos/commit/29475eb58f0a76074b8b992b3013d96689fc228e
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M src/common/ustring.cpp

  Log Message:
  -----------
  COMMON: Guard against UTF-8 exceptions in stricmp too

  Commit: 7e1e41b79d634f55a2ba87ed1744042dc4c27f13
      https://github.com/xoreos/xoreos/commit/7e1e41b79d634f55a2ba87ed1744042dc4c27f13
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M src/engines/nwn/gui/ingame/dialog.cpp

  Log Message:
  -----------
  NWN: Catch all exceptions in the Dialog destructor

  Commit: 99aea31880cf2f32eea75a5f460a98f72f872f5a
      https://github.com/xoreos/xoreos/commit/99aea31880cf2f32eea75a5f460a98f72f872f5a
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M src/engines/nwn2/campaign.cpp

  Log Message:
  -----------
  NWN2: Catch all exceptions in the loadCampaignResource() scope exit

  Commit: 7cdb615213bf3c53cfa59b6d54ef2b30c8692dd2
      https://github.com/xoreos/xoreos/commit/7cdb615213bf3c53cfa59b6d54ef2b30c8692dd2
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    A src/engines/nwn2/inventory.cpp
    A src/engines/nwn2/inventory.h
    M src/engines/nwn2/rules.mk
    M src/engines/nwn2/types.h

  Log Message:
  -----------
  NWN2: Implement inventory class

  Commit: 6a3e36ddc311d8cbbba49ca2c123949e340ef432
      https://github.com/xoreos/xoreos/commit/6a3e36ddc311d8cbbba49ca2c123949e340ef432
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M src/engines/nwn2/creature.cpp
    M src/engines/nwn2/creature.h
    M src/engines/nwn2/inventory.cpp
    M src/engines/nwn2/inventory.h
    M src/engines/nwn2/item.cpp
    M src/engines/nwn2/item.h
    M src/engines/nwn2/object.cpp
    M src/engines/nwn2/object.h
    M src/engines/nwn2/placeable.cpp
    M src/engines/nwn2/placeable.h
    M src/engines/nwn2/script/function_tables.h
    M src/engines/nwn2/script/functions.h
    M src/engines/nwn2/script/functions_inventory.cpp

  Log Message:
  -----------
  NWN2: Integrate inventory with appropriate classes

  Commit: 4a923359271dbddb9aa028feea0b4b29609d070f
      https://github.com/xoreos/xoreos/commit/4a923359271dbddb9aa028feea0b4b29609d070f
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M src/engines/nwn2/inventory.cpp
    M src/engines/nwn2/inventory.h
    M src/engines/nwn2/script/function_tables.h
    M src/engines/nwn2/script/functions.h
    M src/engines/nwn2/script/functions_inventory.cpp

  Log Message:
  -----------
  NWN2: Implement script calls to cycle through inventory

  Commit: 59cb2ac947254af3f5a4f787e54b7d09f204c365
      https://github.com/xoreos/xoreos/commit/59cb2ac947254af3f5a4f787e54b7d09f204c365
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M tests/engines/nwn2/creature.cpp
    A tests/engines/nwn2/creature3.h

  Log Message:
  -----------
  TESTS: Add unit test for NWN2 items and inventory

  Commit: c832c212872061e9db3afc29249afe0c47698864
      https://github.com/xoreos/xoreos/commit/c832c212872061e9db3afc29249afe0c47698864
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-27 (Wed, 27 Feb 2019)

  Changed paths:
    M src/engines/kotor/gui/ingame/hud.cpp
    M src/engines/kotor/gui/ingame/hud.h
    M src/engines/kotor/gui/ingame/ingame.cpp
    M src/engines/kotor/gui/ingame/ingame.h
    M src/engines/kotor/gui/ingame/selectioncircle.cpp
    M src/engines/kotor/gui/ingame/selectioncircle.h
    M src/engines/kotor2/gui/ingame/ingame.cpp
    M src/engines/kotor2/gui/ingame/ingame.h
    M src/engines/kotorbase/gui/ingame.h
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h
    M src/engines/kotorbase/object.cpp
    M src/engines/kotorbase/object.h
    M src/engines/kotorbase/objectcontainer.h
    M src/engines/kotorbase/situated.cpp
    M src/engines/kotorbase/situated.h

  Log Message:
  -----------
  ENGINES: Update selection mechanics to match KotOR games

  Commit: cdfaf8d370debb1cd7ac6111971233b6ed997abd
      https://github.com/xoreos/xoreos/commit/cdfaf8d370debb1cd7ac6111971233b6ed997abd
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M src/aurora/ltrfile.cpp
    A src/common/random.cpp
    A src/common/random.h
    M src/common/rules.mk
    M src/engines/aurora/util.cpp
    M src/engines/dragonage/script/functions_math.cpp
    M src/engines/dragonage2/script/functions_math.cpp
    M src/engines/jade/arealayout.cpp
    M src/engines/jade/script/functions.cpp
    M src/engines/kotor/gui/chargen/chargeninfo.cpp
    M src/engines/kotor2/gui/chargen/chargeninfo.cpp
    M src/engines/kotorbase/script/functions.cpp
    M src/engines/kotorbase/sound.cpp
    M src/engines/nwn/gui/main/newgamefog.cpp
    M src/engines/nwn/script/functions.cpp
    M src/engines/nwn2/creature.cpp
    M src/engines/nwn2/script/functions.cpp
    M src/engines/witcher/nwscript/functions.cpp
    M src/events/events.cpp
    M src/graphics/aurora/animationchannel.cpp

  Log Message:
  -----------
  COMMON: Use random number generation from C++11

  Commit: de1671d96d9e5401d2e4bcc8a667bb22a3369a1a
      https://github.com/xoreos/xoreos/commit/de1671d96d9e5401d2e4bcc8a667bb22a3369a1a
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h
    M src/engines/kotorbase/partycontroller.cpp

  Log Message:
  -----------
  KOTORBASE: Move Module::addPartyMember to PartyController

  Commit: cfcca342eeb2eb91e2d47d1b032414eb20aa28ee
      https://github.com/xoreos/xoreos/commit/cfcca342eeb2eb91e2d47d1b032414eb20aa28ee
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h

  Log Message:
  -----------
  KOTORBASE: Extract minimap initialization to a separate function

  Commit: aca58a6329c43d8ad390cc0ae374d206c35533a1
      https://github.com/xoreos/xoreos/commit/aca58a6329c43d8ad390cc0ae374d206c35533a1
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-28 (Thu, 28 Feb 2019)

  Changed paths:
    M src/engines/kotor/gui/dialog.cpp
    M src/engines/kotor/gui/dialog.h
    M src/engines/kotor/gui/ingame/hud.cpp
    M src/engines/kotor/gui/ingame/hud.h
    M src/engines/kotor/gui/ingame/ingame.cpp
    M src/engines/kotor/gui/ingame/ingame.h
    M src/engines/kotor/gui/ingame/rules.mk
    R src/engines/kotor/gui/ingame/selectioncircle.cpp
    R src/engines/kotor/gui/ingame/selectioncircle.h
    M src/engines/kotor2/gui/chargen/charactergeneration.cpp
    M src/engines/kotor2/gui/chargen/charactergeneration.h
    M src/engines/kotor2/gui/chargen/chargenbase.cpp
    M src/engines/kotor2/gui/chargen/chargenbase.h
    M src/engines/kotor2/gui/chargen/classselection.cpp
    M src/engines/kotor2/gui/chargen/classselection.h
    M src/engines/kotor2/gui/chargen/customchar.cpp
    M src/engines/kotor2/gui/chargen/customchar.h
    M src/engines/kotor2/gui/chargen/quickchar.cpp
    M src/engines/kotor2/gui/chargen/quickchar.h
    M src/engines/kotor2/gui/chargen/quickorcustom.cpp
    M src/engines/kotor2/gui/chargen/quickorcustom.h
    M src/engines/kotor2/gui/dialog.cpp
    M src/engines/kotor2/gui/dialog.h
    M src/engines/kotor2/gui/gui.cpp
    M src/engines/kotor2/gui/gui.h
    M src/engines/kotor2/gui/ingame/hud.cpp
    M src/engines/kotor2/gui/ingame/hud.h
    M src/engines/kotor2/gui/ingame/ingame.cpp
    M src/engines/kotor2/gui/ingame/ingame.h
    M src/engines/kotor2/gui/main/main.cpp
    M src/engines/kotor2/gui/main/main.h
    M src/engines/kotorbase/actionexecutor.cpp
    M src/engines/kotorbase/actionexecutor.h
    M src/engines/kotorbase/gui/dialog.cpp
    M src/engines/kotorbase/gui/dialog.h
    M src/engines/kotorbase/gui/gui.cpp
    A src/engines/kotorbase/gui/hud.cpp
    A src/engines/kotorbase/gui/hud.h
    M src/engines/kotorbase/gui/ingame.cpp
    M src/engines/kotorbase/gui/ingame.h
    M src/engines/kotorbase/gui/rules.mk
    A src/engines/kotorbase/gui/selectioncircle.cpp
    A src/engines/kotorbase/gui/selectioncircle.h
    M src/engines/odyssey/button.cpp
    M src/engines/odyssey/button.h

  Log Message:
  -----------
  ENGINES: Refactor GUI for KotOR games

  Commit: 0e6f07aee463e9d0fcba8ad1acf9cf13081448f0
      https://github.com/xoreos/xoreos/commit/0e6f07aee463e9d0fcba8ad1acf9cf13081448f0
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/situated.cpp
    M src/engines/kotorbase/situated.h

  Log Message:
  -----------
  KOTORBASE: Load KeyRequired property for situated objects

  Commit: 5495166d0ca6db9c34d3533f3f1cb9ecc613a201
      https://github.com/xoreos/xoreos/commit/5495166d0ca6db9c34d3533f3f1cb9ecc613a201
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/door.cpp
    M src/engines/kotorbase/situated.cpp
    M src/engines/kotorbase/situated.h

  Log Message:
  -----------
  KOTORBASE: Make door not usable when opened

  Commit: 60b9e80d4be0c7a94478382681c90ee8e32fac83
      https://github.com/xoreos/xoreos/commit/60b9e80d4be0c7a94478382681c90ee8e32fac83
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/door.cpp
    M src/engines/kotorbase/door.h
    M src/engines/kotorbase/placeable.cpp
    M src/engines/kotorbase/placeable.h

  Log Message:
  -----------
  KOTORBASE: Add methods to unlock doors and placeables

  Commit: f09d4fd0e70093edfa5a6ba0e472f74a9498fc08
      https://github.com/xoreos/xoreos/commit/f09d4fd0e70093edfa5a6ba0e472f74a9498fc08
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/actionexecutor.cpp
    M src/engines/kotorbase/actionexecutor.h

  Log Message:
  -----------
  KOTORBASE: Implement OpenLock action execution

  Commit: 7408d8ec67c340d22af34fd30559e7e3458dd2b8
      https://github.com/xoreos/xoreos/commit/7408d8ec67c340d22af34fd30559e7e3458dd2b8
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/partycontroller.cpp

  Log Message:
  -----------
  KOTORBASE: Return null when party member with invalid index is requested

  Commit: ebc8ba0f12bf97d6cb5984b90083927df7ebecef
      https://github.com/xoreos/xoreos/commit/ebc8ba0f12bf97d6cb5984b90083927df7ebecef
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotor/gui/ingame/hud.cpp
    M src/engines/kotorbase/module.cpp

  Log Message:
  -----------
  KOTOR: Hide selection when entering menus or unloading the module

  Commit: 2f91f16d5fa92288274685786158da0602703f1b
      https://github.com/xoreos/xoreos/commit/2f91f16d5fa92288274685786158da0602703f1b
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h

  Log Message:
  -----------
  KOTORBASE: Extract selection update to a separate Module method

  Commit: 87f4fb5306a07c4820b32da43fe88a32768d9c1c
      https://github.com/xoreos/xoreos/commit/87f4fb5306a07c4820b32da43fe88a32768d9c1c
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/area.cpp
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h

  Log Message:
  -----------
  KOTORBASE: Handle object click in Module first, then in Area

  Commit: 997de0b46617210c8b7cad8a83658ee9c7af9ee1
      https://github.com/xoreos/xoreos/commit/997de0b46617210c8b7cad8a83658ee9c7af9ee1
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/gui/hud.cpp
    M src/engines/kotorbase/gui/hud.h

  Log Message:
  -----------
  KOTORBASE: Refactor HUD, lazy target action update

  Commit: 5f51b851f76114db4f9e074edc4a182e413226e6
      https://github.com/xoreos/xoreos/commit/5f51b851f76114db4f9e074edc4a182e413226e6
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    A src/engines/aurora/flycamera.cpp
    A src/engines/aurora/flycamera.h
    R src/engines/aurora/freeroamcamera.cpp
    R src/engines/aurora/freeroamcamera.h
    M src/engines/aurora/rules.mk
    M src/engines/dragonage/campaigns.cpp
    M src/engines/dragonage2/campaigns.cpp
    M src/engines/jade/module.cpp
    M src/engines/kotor/console.cpp
    M src/engines/kotor2/console.cpp
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h
    M src/engines/nwn/module.cpp
    M src/engines/nwn2/campaign.cpp
    M src/engines/witcher/campaign.cpp

  Log Message:
  -----------
  ENGINES: Rename free-roam camera to flying camera

  Commit: 44592f5f0a7f846072aacec68a3004c5f3653043
      https://github.com/xoreos/xoreos/commit/44592f5f0a7f846072aacec68a3004c5f3653043
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/aurora/rules.mk
    R src/engines/aurora/satellitecamera.cpp
    R src/engines/aurora/satellitecamera.h
    A src/engines/kotorbase/cameracontroller.cpp
    A src/engines/kotorbase/cameracontroller.h
    M src/engines/kotorbase/gui/dialog.cpp
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h
    M src/engines/kotorbase/partyleader.cpp
    M src/engines/kotorbase/rules.mk

  Log Message:
  -----------
  ENGINES: Replace satellite camera with camera controller for KotOR games

  Commit: 059def630809e09ec5ab076480a2cbab0ceb3457
      https://github.com/xoreos/xoreos/commit/059def630809e09ec5ab076480a2cbab0ceb3457
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotorbase/area.cpp
    M src/engines/kotorbase/area.h
    M src/engines/kotorbase/cameracontroller.cpp

  Log Message:
  -----------
  KOTORBASE: Implement collision detection for the satellite camera

  Commit: bf8b258102c585315cf18e786a2ea35fa831ea0c
      https://github.com/xoreos/xoreos/commit/bf8b258102c585315cf18e786a2ea35fa831ea0c
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotor/kotor.cpp
    M src/engines/kotorbase/area.cpp
    M src/engines/kotorbase/area.h
    M src/engines/kotorbase/cameracontroller.cpp

  Log Message:
  -----------
  ENGINES: Set perspective as part of the camera style in KotOR games

  Commit: 8014e457706d69eef1f55a12cced8cf5dc0c0063
      https://github.com/xoreos/xoreos/commit/8014e457706d69eef1f55a12cced8cf5dc0c0063
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotor/console.cpp
    M src/engines/kotor/game.cpp
    M src/engines/kotor/game.h
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor2/console.cpp
    M src/engines/kotor2/game.cpp
    M src/engines/kotor2/game.h
    M src/engines/kotor2/script/function_tables.h
    M src/engines/kotorbase/game.h
    M src/engines/kotorbase/script/functions.h
    M src/engines/kotorbase/script/functions_module.cpp

  Log Message:
  -----------
  KOTOR: Implement NWScript function StartNewModule

Called by the KotOR2 script to skip the prologue.

  Commit: 98e7051468fe7f2b21af78527bff4092814a17df
      https://github.com/xoreos/xoreos/commit/98e7051468fe7f2b21af78527bff4092814a17df
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    A src/engines/kotorbase/location.cpp
    A src/engines/kotorbase/location.h
    M src/engines/kotorbase/object.cpp
    M src/engines/kotorbase/object.h
    M src/engines/kotorbase/objectcontainer.cpp
    M src/engines/kotorbase/objectcontainer.h
    M src/engines/kotorbase/rules.mk

  Log Message:
  -----------
  KOTORBASE: Add a Location EngineType class

  Commit: 9093585c1c858b5a620acd9c6c6184002fd860e0
      https://github.com/xoreos/xoreos/commit/9093585c1c858b5a620acd9c6c6184002fd860e0
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor2/script/function_tables.h
    M src/engines/kotorbase/script/functions.h
    M src/engines/kotorbase/script/functions_object.cpp

  Log Message:
  -----------
  KOTOR: Implement NWScript function GetLocation

  Commit: c68c3e7cd9a99893f83f658a633e49d740ad343a
      https://github.com/xoreos/xoreos/commit/c68c3e7cd9a99893f83f658a633e49d740ad343a
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor2/script/function_tables.h
    M src/engines/kotorbase/script/functions.h
    M src/engines/kotorbase/script/functions_object.cpp

  Log Message:
  -----------
  KOTOR: Implement NWScript function JumpToLocation

This makes the first "real" area of KotOR2 more playable: the player
is moved out of the kolto tank during the opening cutscene.

  Commit: f5ff1f167b7c6652f56075f731450beb8ebfca53
      https://github.com/xoreos/xoreos/commit/f5ff1f167b7c6652f56075f731450beb8ebfca53
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-03-02 (Sat, 02 Mar 2019)

  Changed paths:
    M src/common/system.h

  Log Message:
  -----------
  COMMON: Add version check around MSVC (v)snprintf compatibility layer

Visual Studio 2015 apparently fixed the issue by implementing a proper
C99-compliant (v)snprintf. Boost 1.69.0 depends on that, breaking
compilation with our version-unrestricted #define.

Compare: https://github.com/xoreos/xoreos/compare/82273fc5fe13...f5ff1f167b7c