[xoreos-git] [xoreos/xoreos] 7aec77: COMMON: Guard against invalid_utf8 exceptions in U...

Vsevolod Kremianskii noreply at github.com
Mon Feb 25 23:42:20 CET 2019


  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/xoreos
  Commit: 7aec77b0854ed6760f771fd50017ab546ebe2868
      https://github.com/xoreos/xoreos/commit/7aec77b0854ed6760f771fd50017ab546ebe2868
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/common/ustring.cpp

  Log Message:
  -----------
  COMMON: Guard against invalid_utf8 exceptions in UString::strcmp()


  Commit: 769cb854566d20bacb7bcfddcbde3ccda5e67e1b
      https://github.com/xoreos/xoreos/commit/769cb854566d20bacb7bcfddcbde3ccda5e67e1b
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/aurora/nwscript/variable.cpp

  Log Message:
  -----------
  AURORA: Catch all exceptions in the NWScript Variable destructor

This fixes Coverity Scan issue #1399032.


  Commit: 25bec064112786ae6f201151e3605a6c148d0411
      https://github.com/xoreos/xoreos/commit/25bec064112786ae6f201151e3605a6c148d0411
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/aurora/lua/variable.cpp

  Log Message:
  -----------
  AURORA: Catch all exceptions in the Lua Variable destructor

This fixes Coverity Scan issue #1399025.


  Commit: 6c703a99f1d9c40e2186d6f47df59ca4c310a6b8
      https://github.com/xoreos/xoreos/commit/6c703a99f1d9c40e2186d6f47df59ca4c310a6b8
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/graphics/graphics.cpp

  Log Message:
  -----------
  GRAPHICS: Catch all exceptions in the GraphicsManager destructor

This fixes Coverity Scan issue #1399021.


  Commit: 4436356405e36a680139650903af5fd68a62d842
      https://github.com/xoreos/xoreos/commit/4436356405e36a680139650903af5fd68a62d842
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/aurora/console.cpp

  Log Message:
  -----------
  ENGINES: Catch all exceptions in the ConsoleWindow destructor

This fixes Coverity Scan issue #1399019.


  Commit: 68ecfffd30e26c0867aafe074d2149f59eeb9e6d
      https://github.com/xoreos/xoreos/commit/68ecfffd30e26c0867aafe074d2149f59eeb9e6d
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/aurora/console.cpp

  Log Message:
  -----------
  ENGINES: Catch all exceptions in the Console destructor

This fixes Coverity Scan issue #1399016.


  Commit: d61af991f8198ded8a1b05f400b148aaa9cc21ce
      https://github.com/xoreos/xoreos/commit/d61af991f8198ded8a1b05f400b148aaa9cc21ce
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/jade/room.cpp

  Log Message:
  -----------
  JADE: Catch all exceptions in the Room destructor

This fixes Coverity Scan issue #1399013.


  Commit: 2c620ae7ff5c80d801092717bddc7f7b00643f80
      https://github.com/xoreos/xoreos/commit/2c620ae7ff5c80d801092717bddc7f7b00643f80
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/graphics/aurora/cursorman.cpp

  Log Message:
  -----------
  GRAPHICS: Catch all exceptions in the CursorManager destructor

This fixes Coverity Scan issue #1399002.


  Commit: 0e2f8278d0a9aa2575a11e6e29ceadc33a59f886
      https://github.com/xoreos/xoreos/commit/0e2f8278d0a9aa2575a11e6e29ceadc33a59f886
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotorbase/gui/loadscreen.cpp
    M src/engines/kotorbase/gui/loadscreen.h

  Log Message:
  -----------
  KOTORBASE: Initialize LoadScreen::_progressBar

This fixes Coverity Scan issue #1399011.


  Commit: 658d1d3f42c5a45c47024081a3d3f79bb8470b06
      https://github.com/xoreos/xoreos/commit/658d1d3f42c5a45c47024081a3d3f79bb8470b06
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/nwn/walkmeshloader.cpp

  Log Message:
  -----------
  NWN: Make sure we don't deref a nullptr in the WalkmeshLoader

This fixes Coverity Scan issue #1399041.


  Commit: 251d2c023a3223651360b4277ce0cce529ac30cc
      https://github.com/xoreos/xoreos/commit/251d2c023a3223651360b4277ce0cce529ac30cc
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/aurora/localpathfinding.cpp

  Log Message:
  -----------
  ENGINES: Change dynamic_cast from * to & in LocalAStar

So that it throws instead of dereferencing a nullptr on cast fail.

This fixes Coverity Scan issue #1398997.


  Commit: 3edb742ee543f678efa449955d34c02f864e7648
      https://github.com/xoreos/xoreos/commit/3edb742ee543f678efa449955d34c02f864e7648
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/nwn/gui/chargen/charfeats.cpp
    M src/engines/nwn/gui/chargen/charfeats.h
    M src/engines/nwn/gui/chargen/charskills.cpp
    M src/engines/nwn/gui/chargen/charskills.h

  Log Message:
  -----------
  NWN: Pass structures by const ref instead of value in char gen


  Commit: 6bf8fe5f8eb4575ed63209b432747233220ae235
      https://github.com/xoreos/xoreos/commit/6bf8fe5f8eb4575ed63209b432747233220ae235
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotorbase/creature.h

  Log Message:
  -----------
  KOTORBASE: Initialize Creature ability scores


  Commit: edd15e15466875676b947a821e47207eb76e5b53
      https://github.com/xoreos/xoreos/commit/edd15e15466875676b947a821e47207eb76e5b53
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/aurora/pathfinding.cpp

  Log Message:
  -----------
  ENGINES: Initialize Pathfinding::_walkmeshVisible


  Commit: 3ce4a8c8678c1b72b24bd8e94c0e1ced4999d508
      https://github.com/xoreos/xoreos/commit/3ce4a8c8678c1b72b24bd8e94c0e1ced4999d508
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    A src/engines/nwn2/item.cpp
    A src/engines/nwn2/item.h
    M src/engines/nwn2/rules.mk
    M src/engines/nwn2/types.h

  Log Message:
  -----------
  NWN2: Add item class


  Commit: 9d51da69a334886f5ba39893999c1e23ebb1a383
      https://github.com/xoreos/xoreos/commit/9d51da69a334886f5ba39893999c1e23ebb1a383
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/nwn2/item.cpp
    M src/engines/nwn2/item.h

  Log Message:
  -----------
  NWN2: Implement item get calls


  Commit: cdeaea250290b57b6e46dc3611919d271bd95f7c
      https://github.com/xoreos/xoreos/commit/cdeaea250290b57b6e46dc3611919d271bd95f7c
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/nwn2/objectcontainer.cpp
    M src/engines/nwn2/objectcontainer.h
    M src/engines/nwn2/script/function_tables.h
    M src/engines/nwn2/script/functions.h
    M src/engines/nwn2/script/functions_creature.cpp
    A src/engines/nwn2/script/functions_inventory.cpp
    M src/engines/nwn2/script/rules.mk

  Log Message:
  -----------
  NWN2: Implement item get* script calls


  Commit: 98037b2b9cc21d71a8c8d6d4c96b905c334187be
      https://github.com/xoreos/xoreos/commit/98037b2b9cc21d71a8c8d6d4c96b905c334187be
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/nwn2/item.cpp
    M src/engines/nwn2/item.h

  Log Message:
  -----------
  NWN2: Implement item set calls


  Commit: 3297b5a585e4036273170232496b8605d953546b
      https://github.com/xoreos/xoreos/commit/3297b5a585e4036273170232496b8605d953546b
  Author: Bob Hall <rjh405 at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/nwn2/script/function_tables.h
    M src/engines/nwn2/script/functions.h
    M src/engines/nwn2/script/functions_creature.cpp
    M src/engines/nwn2/script/functions_inventory.cpp

  Log Message:
  -----------
  NWN2: Implement item set* script calls


  Commit: a5effb798619efc65d9bb8cdc06fdd9faf0085eb
      https://github.com/xoreos/xoreos/commit/a5effb798619efc65d9bb8cdc06fdd9faf0085eb
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotor/module.cpp
    M src/engines/kotor/module.h
    M src/engines/kotor2/module.cpp
    M src/engines/kotor2/module.h
    M src/engines/kotorbase/module.h

  Log Message:
  -----------
  ENGINES: Cleanup module declarations in KotOR games


  Commit: fb6bdea9a2af309f9ba1812b98a8ec9a093b7883
      https://github.com/xoreos/xoreos/commit/fb6bdea9a2af309f9ba1812b98a8ec9a093b7883
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h
    A src/engines/kotorbase/partyleader.cpp
    A src/engines/kotorbase/partyleader.h
    R src/engines/kotorbase/playercontroller.cpp
    R src/engines/kotorbase/playercontroller.h
    M src/engines/kotorbase/rules.mk

  Log Message:
  -----------
  KOTORBASE: Refactor player controller

We control the party leader, not the player character. Also, no need to
set a pointer to the character, since we already have a pointer to the
module.


  Commit: 811dac00c8058812e0eb44320499dcf4488b7b35
      https://github.com/xoreos/xoreos/commit/811dac00c8058812e0eb44320499dcf4488b7b35
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotorbase/area.cpp
    M src/engines/kotorbase/area.h

  Log Message:
  -----------
  KOTORBASE: Extract method to add creature to the area


  Commit: 8c70b25cb760c11fe07f64636dd174be5dfd8493
      https://github.com/xoreos/xoreos/commit/8c70b25cb760c11fe07f64636dd174be5dfd8493
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotor/gui/chargen/chargeninfo.cpp
    M src/engines/kotor/gui/chargen/chargeninfo.h
    M src/engines/kotor/module.cpp
    M src/engines/kotor/module.h
    M src/engines/kotor2/gui/chargen/chargeninfo.cpp
    M src/engines/kotor2/gui/chargen/chargeninfo.h
    M src/engines/kotor2/module.cpp
    M src/engines/kotor2/module.h
    M src/engines/kotorbase/module.h

  Log Message:
  -----------
  ENGINES: Add Module method to create chargeninfo for KotOR games


  Commit: cb34315ebf228111807009b7b530c7907aee7318
      https://github.com/xoreos/xoreos/commit/cb34315ebf228111807009b7b530c7907aee7318
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotor/gui/ingame/menu.cpp

  Log Message:
  -----------
  KOTOR: Always update the pointer to the PC in equipment menu

Otherwise, it will crash on module change.


  Commit: 110e9d25f8712d83878c83dd376981f332007509
      https://github.com/xoreos/xoreos/commit/110e9d25f8712d83878c83dd376981f332007509
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotor2/kotor2.cpp

  Log Message:
  -----------
  KOTOR2: Fix crash when toggling the free roam camera


  Commit: 561383f6e6a05e0adf892401361f17700c5c0394
      https://github.com/xoreos/xoreos/commit/561383f6e6a05e0adf892401361f17700c5c0394
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotorbase/gui/inventoryitem.cpp
    M src/engines/kotorbase/gui/inventoryitem.h

  Log Message:
  -----------
  KOTORBASE: Fix WidgetInventoryItem constructor parameters


  Commit: 6438aa3109eac4a09f60d836ae3758a8b199dfbe
      https://github.com/xoreos/xoreos/commit/6438aa3109eac4a09f60d836ae3758a8b199dfbe
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotor/gui/ingame/menu.cpp
    M src/engines/kotor/gui/ingame/menu_equ.cpp
    M src/engines/kotor/gui/ingame/menu_equ.h
    M src/engines/kotorbase/area.cpp
    M src/engines/kotorbase/area.h

  Log Message:
  -----------
  KOTOR: Fix selection of PC after equipping armor


  Commit: 87e25a4a37b45aed8f31e5d8a7f013f3e26fd537
      https://github.com/xoreos/xoreos/commit/87e25a4a37b45aed8f31e5d8a7f013f3e26fd537
  Author: Vsevolod Kremianskii <vkremianskii at gmail.com>
  Date:   2019-02-25 (Mon, 25 Feb 2019)

  Changed paths:
    M src/engines/kotor/gui/chargen/charactergeneration.cpp
    M src/engines/kotor/gui/ingame/hud.cpp
    M src/engines/kotor/savedgame.cpp
    M src/engines/kotor/savedgame.h
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor2/gui/chargen/charactergeneration.cpp
    M src/engines/kotor2/script/function_tables.h
    M src/engines/kotorbase/action.cpp
    M src/engines/kotorbase/action.h
    M src/engines/kotorbase/actionexecutor.cpp
    M src/engines/kotorbase/area.cpp
    M src/engines/kotorbase/area.h
    M src/engines/kotorbase/creature.cpp
    M src/engines/kotorbase/creature.h
    M src/engines/kotorbase/door.cpp
    M src/engines/kotorbase/module.cpp
    M src/engines/kotorbase/module.h
    M src/engines/kotorbase/object.cpp
    M src/engines/kotorbase/object.h
    A src/engines/kotorbase/partycontroller.cpp
    A src/engines/kotorbase/partycontroller.h
    M src/engines/kotorbase/partyleader.cpp
    M src/engines/kotorbase/rules.mk
    M src/engines/kotorbase/savedgame.cpp
    M src/engines/kotorbase/savedgame.h
    M src/engines/kotorbase/script/functions.h
    M src/engines/kotorbase/script/functions_party.cpp

  Log Message:
  -----------
  ENGINES: Refactor PC and party management in KotOR games


Compare: https://github.com/xoreos/xoreos/compare/4c7f9bfa2b6f...87e25a4a37b4



More information about the xoreos-git mailing list