[xoreos-git] [xoreos/phaethon] 8b732e: TESTS: Assert if size < 0 in gtest's GetFileSize()
GitHub
noreply at github.com
Mon May 28 17:26:04 CEST 2018
Branch: refs/heads/coverity_scan
Home: https://github.com/xoreos/phaethon
Commit: 8b732e301e95f0d81a7f43861baaced3e9c9104e
https://github.com/xoreos/phaethon/commit/8b732e301e95f0d81a7f43861baaced3e9c9104e
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-23 (Wed, 23 May 2018)
Changed paths:
M tests/googletest/src/gtest-port.cc
Log Message:
-----------
TESTS: Assert if size < 0 in gtest's GetFileSize()
Commit: 27e1f08bb2bed00b7b7c6c30b0c5225a6d1e2ea9
https://github.com/xoreos/phaethon/commit/27e1f08bb2bed00b7b7c6c30b0c5225a6d1e2ea9
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-23 (Wed, 23 May 2018)
Changed paths:
M src/gui/resourcetreeitem.cpp
Log Message:
-----------
GUI: Initialize ResourceTreeItem::_parent
This fixes Coverity Scan issues #190227 and #190232.
Commit: a6cb6af7edda8f0985a3c3aa99f2fdf1967108c9
https://github.com/xoreos/phaethon/commit/a6cb6af7edda8f0985a3c3aa99f2fdf1967108c9
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-23 (Wed, 23 May 2018)
Changed paths:
M src/gui/resourcetreeitem.cpp
M src/gui/resourcetreeitem.h
Log Message:
-----------
GUI: Initialize all members in the ResourceTreeItem root constructor
This fixes Coverity Scan issue #190231.
Commit: bdb5750526c33f1d4f35f2cfcd90747d0156bde2
https://github.com/xoreos/phaethon/commit/bdb5750526c33f1d4f35f2cfcd90747d0156bde2
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-23 (Wed, 23 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
Log Message:
-----------
GUI: Fix garbage in exported filename
Commit: bf843ff5df29cb9b64b3974fe19aa332e0476435
https://github.com/xoreos/phaethon/commit/bf843ff5df29cb9b64b3974fe19aa332e0476435
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-23 (Wed, 23 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
M src/gui/mainwindow.h
Log Message:
-----------
GUI: Fix panels leaking when left without a parent
Commit: 31820f26e169255c8f3d7f5c5b48a1fcf2b7d78e
https://github.com/xoreos/phaethon/commit/31820f26e169255c8f3d7f5c5b48a1fcf2b7d78e
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-23 (Wed, 23 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
M src/gui/mainwindow.h
M src/gui/resourcetree.cpp
Log Message:
-----------
GUI: Fix QFutureWatcher leaking by giving it a parent
Commit: fb12c7dbbd4c507b85bea5b983e28993471e868a
https://github.com/xoreos/phaethon/commit/fb12c7dbbd4c507b85bea5b983e28993471e868a
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/aurora/types.h
M src/aurora/util.cpp
Log Message:
-----------
AURORA: Add text resource type
Commit: 7304607c8a640df77b91e782a9bf0ed05d8f897d
https://github.com/xoreos/phaethon/commit/7304607c8a640df77b91e782a9bf0ed05d8f897d
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M ChangeLog
M src/gui/mainwindow.cpp
M src/gui/mainwindow.h
A src/gui/panelpreviewtext.cpp
A src/gui/panelpreviewtext.h
M src/gui/rules.mk
Log Message:
-----------
GUI: Add text preview
Commit: bea327fd367cf7c9dd0f3579fe6d4af084b03c04
https://github.com/xoreos/phaethon/commit/bea327fd367cf7c9dd0f3579fe6d4af084b03c04
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/mainwindow.h
M src/gui/panelpreviewempty.h
M src/gui/panelpreviewimage.h
M src/gui/panelpreviewsound.h
M src/gui/panelpreviewtext.h
M src/gui/panelresourceinfo.h
M src/gui/proxymodel.h
M src/gui/resourcetree.h
M src/gui/resourcetreeitem.h
M src/gui/statusbar.h
Log Message:
-----------
GUI: Give the include guards a GUI_ prefix
Commit: d0b989b611d7c005557f78fb85e180e5f3dae7d0
https://github.com/xoreos/phaethon/commit/d0b989b611d7c005557f78fb85e180e5f3dae7d0
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/proxymodel.cpp
M src/gui/proxymodel.h
Log Message:
-----------
GUI: Add missing copyright headers
Commit: f81622fa0d305efa31f20d5d20860ec1336aa692
https://github.com/xoreos/phaethon/commit/f81622fa0d305efa31f20d5d20860ec1336aa692
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/panelpreviewimage.cpp
M src/gui/resourcetree.h
Log Message:
-----------
GUI: Fix minor indentation mistakes
Commit: 051af61b8ec95de1df8db375cf35ac81738acd20
https://github.com/xoreos/phaethon/commit/051af61b8ec95de1df8db375cf35ac81738acd20
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
Log Message:
-----------
GUI: Make log read-only
Commit: fb3c47f02d510f0401cf0b29bbd2681213440961
https://github.com/xoreos/phaethon/commit/fb3c47f02d510f0401cf0b29bbd2681213440961
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
Log Message:
-----------
GUI: Only set item for the relevant panel
Commit: 9e1356eed3965fe539b71617e75d9ca5dbafa831
https://github.com/xoreos/phaethon/commit/9e1356eed3965fe539b71617e75d9ca5dbafa831
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
Log Message:
-----------
GUI: Change log text when you call "close"
"Closed directory" -> "Closed", it's not necessarily
a directory.
Commit: ed8c9e6e4a1e1df290b9076e477682e9b6d7e104
https://github.com/xoreos/phaethon/commit/ed8c9e6e4a1e1df290b9076e477682e9b6d7e104
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
Log Message:
-----------
GUI: Call close before opening something new
Commit: 3faa5a311644f715f0027402a9dff06a94520d3f
https://github.com/xoreos/phaethon/commit/3faa5a311644f715f0027402a9dff06a94520d3f
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/gui/panelpreviewempty.cpp
M src/gui/panelpreviewempty.h
M src/gui/panelpreviewimage.cpp
M src/gui/panelpreviewimage.h
M src/gui/panelpreviewsound.cpp
M src/gui/panelpreviewsound.h
M src/gui/panelpreviewtext.cpp
M src/gui/panelpreviewtext.h
M src/gui/panelresourceinfo.cpp
M src/gui/panelresourceinfo.h
M src/gui/resourcetree.cpp
M src/gui/resourcetree.h
M src/gui/resourcetreeitem.h
M src/gui/statusbar.cpp
M src/gui/statusbar.h
Log Message:
-----------
GUI: Clean up includes
Commit: 702d93c55d97f099565e4a0a867a50879c726ff3
https://github.com/xoreos/phaethon/commit/702d93c55d97f099565e4a0a867a50879c726ff3
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/common/disposableptr.h
M src/common/scopedptr.h
M src/common/system.h
Log Message:
-----------
COMMON: Rename XOREOS_EXPLICIT_OPERATOR_CONV to PHAETHON_
Commit: a80d1e71d7fd30b173cf5f7171b827fd42e7dbbf
https://github.com/xoreos/phaethon/commit/a80d1e71d7fd30b173cf5f7171b827fd42e7dbbf
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
A utf8cpp/README.Phaethon
R utf8cpp/README.xoreos
M utf8cpp/rules.mk
Log Message:
-----------
UTF8: Rename README.xoreos to README.Phaethon
Commit: 58d98b308c493bf003c8bd8b2cc90faa230a4233
https://github.com/xoreos/phaethon/commit/58d98b308c493bf003c8bd8b2cc90faa230a4233
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
A tests/googletest/README.Phaethon
R tests/googletest/README.xoreos
M tests/googletest/rules.mk
Log Message:
-----------
TESTS: Rename README.xoreos to README.Phaethon
Commit: 814cdb1eb697e628e9a3534862d3ad408e97a613
https://github.com/xoreos/phaethon/commit/814cdb1eb697e628e9a3534862d3ad408e97a613
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/common/system.h
Log Message:
-----------
COMMON: Add a PHAETHON_FALLTHROUGH macro
While gcc can parse the "// Fallthrough" comments we use to mark
switch case fallthroughs, clang can not. Instead, clang wants a
[[clang::fallthrough]] attribute.
So we use the PHAETHON_FALLTHROUGH macro to select the appropriate
way to mark a fallthrough.
Commit: 929ad03df3cb8714b0bd68acb5704df48ecb0c21
https://github.com/xoreos/phaethon/commit/929ad03df3cb8714b0bd68acb5704df48ecb0c21
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/common/readstream.cpp
Log Message:
-----------
COMMON: Use the PHAETHON_FALLTHROUGH macro to mark fallthroughs
Commit: 7303d37d6aa3e01712d6b0bf4cb56780e95310d5
https://github.com/xoreos/phaethon/commit/7303d37d6aa3e01712d6b0bf4cb56780e95310d5
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M src/sound/decoders/wma.cpp
Log Message:
-----------
SOUND: Use the PHAETHON_FALLTHROUGH macro to mark fallthroughs
Commit: 5b9c2933c6ceda95a6923959f8bdf2a48066b2f8
https://github.com/xoreos/phaethon/commit/5b9c2933c6ceda95a6923959f8bdf2a48066b2f8
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M m4/boost.m4
Log Message:
-----------
BUILD: Extend boost.m4 to recognize gcc 5.4 and 5.5
Commit: 8a68d7cf7c64c12563229047445a876d3d8c16c4
https://github.com/xoreos/phaethon/commit/8a68d7cf7c64c12563229047445a876d3d8c16c4
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M configure.ac
Log Message:
-----------
BUILD: Unconditionally disable certain extra compiler warnings
The configure option --without-warnings is about not enabling certain
extra warning flags.
Regardless of that option, we always want to disable certain warnings.
Commit: cea81bc74ebf52611e3879d0864971536f507e23
https://github.com/xoreos/phaethon/commit/cea81bc74ebf52611e3879d0864971536f507e23
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M CMakeLists.txt
M configure.ac
Log Message:
-----------
BUILD: Disable the -Wundefined-var-template compiler warning
clang is far too trigger-happy there, spamming the warning everwhere
our Singleton template is used.
Commit: dc4e0363093980adb2869184f058f8d7e7edd55c
https://github.com/xoreos/phaethon/commit/dc4e0363093980adb2869184f058f8d7e7edd55c
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M CMakeLists.txt
M configure.ac
Log Message:
-----------
BUILD: Disable the -Winconsistent-missing-override compiler warning
We do not yet mark any of our overrides.
Commit: e0ee6c7b0eb7dcb0c93b139a9619577277ee8f2c
https://github.com/xoreos/phaethon/commit/e0ee6c7b0eb7dcb0c93b139a9619577277ee8f2c
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M Makefile.am
Log Message:
-----------
BUILD: Use LIBSL_PHAETHON instead of LIBSL_XOREOS
Commit: 3318626f4bccda2e53ad5332b7a2aca2a1eea221
https://github.com/xoreos/phaethon/commit/3318626f4bccda2e53ad5332b7a2aca2a1eea221
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
M tests/skip.h
Log Message:
-----------
TESTS: Use the correct copyright header
Commit: 48628c48ecede4640d7302f46c95bf4ec7bc77ec
https://github.com/xoreos/phaethon/commit/48628c48ecede4640d7302f46c95bf4ec7bc77ec
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-25 (Fri, 25 May 2018)
Changed paths:
A src/common/fallthrough.h
M src/common/rules.mk
M src/common/system.h
Log Message:
-----------
COMMON: Move PHAETHON_FALLTHROUGH into its own file, fallthrough.h
To be more in line with xoreos.
Commit: cca9e12df2aeb5aca7de7679a6da09110a6b39ef
https://github.com/xoreos/phaethon/commit/cca9e12df2aeb5aca7de7679a6da09110a6b39ef
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-26 (Sat, 26 May 2018)
Changed paths:
M src/gui/panelresourceinfo.cpp
Log Message:
-----------
GUI: Make resource name label not take too much space
With really long filenames it shrunk the tree
in order to fit.
Commit: cd697c396c09cf3fed80c730fd2ffc4b42605db9
https://github.com/xoreos/phaethon/commit/cd697c396c09cf3fed80c730fd2ffc4b42605db9
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-26 (Sat, 26 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
M src/gui/mainwindow.h
Log Message:
-----------
GUI: Don't log "Closed: " text when opening something
Commit: 5add85651743831a9883b93c097affb251b833fd
https://github.com/xoreos/phaethon/commit/5add85651743831a9883b93c097affb251b833fd
Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
Date: 2018-05-28 (Mon, 28 May 2018)
Changed paths:
M src/gui/mainwindow.cpp
Log Message:
-----------
GUI: Add key shortcuts
Commit: 9a8f83b275a1531639323ec22fb30b13388d71e0
https://github.com/xoreos/phaethon/commit/9a8f83b275a1531639323ec22fb30b13388d71e0
Author: patrick <nostritius at googlemail.com>
Date: 2018-05-28 (Mon, 28 May 2018)
Changed paths:
M .travis.yml
Log Message:
-----------
BUILD: Add travis osx support
Commit: 8d5b5197898456ded3b3be6b6e5c4a3744ccc767
https://github.com/xoreos/phaethon/commit/8d5b5197898456ded3b3be6b6e5c4a3744ccc767
Author: patrick <nostritius at googlemail.com>
Date: 2018-05-28 (Mon, 28 May 2018)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
BUILD: Fix an osx brew qt5 dependency path problem in cmake
Commit: 05e0bdcd33b886b1c3945f5026700a08ca0031d4
https://github.com/xoreos/phaethon/commit/05e0bdcd33b886b1c3945f5026700a08ca0031d4
Author: Sven Hesse <drmccoy at drmccoy.de>
Date: 2018-05-28 (Mon, 28 May 2018)
Changed paths:
M .travis.yml
Log Message:
-----------
BUILD: Only install packages on Travis if we're actually building
The Coverity Scan builds bail before compilation. We don't need to
install packages there then.
Compare: https://github.com/xoreos/phaethon/compare/ae338917968f...05e0bdcd33b8
**NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
More information about the xoreos-git
mailing list