[xoreos-git] [xoreos/xoreos] 52c778: KOTOR: Protect against a division by zero in Widge...

[GitHub]

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/xoreos
  Commit: 52c7785a28c189d26ab28e45b56be2e376d28d73
      https://github.com/xoreos/xoreos/commit/52c7785a28c189d26ab28e45b56be2e376d28d73
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/widgets/listbox.cpp
    M src/engines/kotor/gui/widgets/listbox.h

  Log Message:
  -----------
  KOTOR: Protect against a division by zero in WidgetListBox

If the listbox items have a height of zero (or no defined height at
all), calculating the number of widget would provoke a division by
zero.

This fixes Coverity Scan issue #1391035.


  Commit: a914c126282ef45ce161c504d23dbc38682283d7
      https://github.com/xoreos/xoreos/commit/a914c126282ef45ce161c504d23dbc38682283d7
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/chargen/chargeninfo.h

  Log Message:
  -----------
  KOTOR: Add missing include


  Commit: 1ee7c2031807e76f7cceb2b584ac8b4a57df9a16
      https://github.com/xoreos/xoreos/commit/1ee7c2031807e76f7cceb2b584ac8b4a57df9a16
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/creature.cpp
    M src/engines/kotor/creature.h
    M src/engines/kotor/gui/chargen/chargeninfo.cpp
    M src/engines/kotor/gui/chargen/chargeninfo.h

  Log Message:
  -----------
  KOTOR: Enforce const-correctness in the character generator more


  Commit: 60e1a90d19d96dd895e2f67d69b3803b0de0123b
      https://github.com/xoreos/xoreos/commit/60e1a90d19d96dd895e2f67d69b3803b0de0123b
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/creature.cpp
    M src/engines/kotor/creature.h
    M src/engines/kotor/gui/chargen/chargeninfo.cpp

  Log Message:
  -----------
  KOTOR: Change Creature::createPC() to take a reference, not a pointer

It needs a CharacterGenerationInfo, which can't be 0.


  Commit: 3afcb992f5738e965b4b4488d44696266657f1e5
      https://github.com/xoreos/xoreos/commit/3afcb992f5738e965b4b4488d44696266657f1e5
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/chargen/chargeninfo.cpp

  Log Message:
  -----------
  KOTOR: Fix a potential leak in CharacterGenerationInfo::getCharacter()

Creature::createPC() can throw. When it does, the Creature will be
leaked.


  Commit: 538d38537dfb45c65559ef54614eaa14f4bae1a3
      https://github.com/xoreos/xoreos/commit/538d38537dfb45c65559ef54614eaa14f4bae1a3
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/savedgame.cpp

  Log Message:
  -----------
  KOTOR: Don't leak the CharacterGenerationInfo in SavedGame::getPC()

This fixes Coverity Scan issue #1391040.


  Commit: 72d529bbbbd8aace40c65fa5ddce1434cb6e800d
      https://github.com/xoreos/xoreos/commit/72d529bbbbd8aace40c65fa5ddce1434cb6e800d
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor2/gui/chargen/chargeninfo.cpp

  Log Message:
  -----------
  KOTOR2: Fix potential leak in CharacterGenerationInfo::getCharacter()

Creature::createPC() could throw. When it does, the Creature will be
leaked.


  Commit: 4ac25e4c2b9abd54595f33fc9bfb635cee249cff
      https://github.com/xoreos/xoreos/commit/4ac25e4c2b9abd54595f33fc9bfb635cee249cff
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor2/creature.cpp
    M src/engines/kotor2/creature.h
    M src/engines/kotor2/gui/chargen/chargeninfo.cpp

  Log Message:
  -----------
  KOTOR2: Change Creature::createPC() to take a reference, not a pointer

It needs a CharacterGenerationInfo, which can't be 0.


  Commit: 44bea776fce92bb98373116c57366f80a479ca71
      https://github.com/xoreos/xoreos/commit/44bea776fce92bb98373116c57366f80a479ca71
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/widgets/listbox.cpp

  Log Message:
  -----------
  KOTOR: Make listbox click detection more robust


  Commit: 0708677ce71b0de09927587e3294b4b7dd41bafd
      https://github.com/xoreos/xoreos/commit/0708677ce71b0de09927587e3294b4b7dd41bafd
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/chargen/chargeninfo.cpp

  Log Message:
  -----------
  KOTOR: Mark code duplication in CharacterGenerationInfo::getModel()


  Commit: 6c45374ddd1a978f2c636245635ea74256d98956
      https://github.com/xoreos/xoreos/commit/6c45374ddd1a978f2c636245635ea74256d98956
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/saveload.cpp

  Log Message:
  -----------
  KOTOR: Correct save number parsing

Apparently, the original game completely ignores the "GameXX" string
in the save directory, and instead uses the number in front.


  Commit: d718396312397abb8a54307c48e5fb3b0f20c1e9
      https://github.com/xoreos/xoreos/commit/d718396312397abb8a54307c48e5fb3b0f20c1e9
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/saveload.cpp

  Log Message:
  -----------
  KOTOR: Improve error reporting on save number/type parsing


  Commit: c19522df4ef8e554267cfa98149393b8dbc468c3
      https://github.com/xoreos/xoreos/commit/c19522df4ef8e554267cfa98149393b8dbc468c3
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/engines/kotor/gui/saveload.cpp

  Log Message:
  -----------
  KOTOR: Sort savegame list alphanumerical

This seems to be what the original game does as well.


Compare: https://github.com/xoreos/xoreos/compare/73af8857797e...c19522df4ef8
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.