[xoreos-git] [xoreos/phaethon] 335fa2: SOUND: Fix WMA decoding broken in 7303d37d6

GitHub noreply at github.com
Wed Jun 6 21:50:31 CEST 2018


  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/phaethon
  Commit: 335fa297eb15793262a77bf19e9c3b64fa5cf473
      https://github.com/xoreos/phaethon/commit/335fa297eb15793262a77bf19e9c3b64fa5cf473
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-06-06 (Wed, 06 Jun 2018)

  Changed paths:
    M src/sound/decoders/wma.cpp

  Log Message:
  -----------
  SOUND: Fix WMA decoding broken in 7303d37d6

Because of Duff's Device, the break would be for the loop, not for the
switch. Putting a break there to shut the compiler up about the
fall-through is wrong. Instead, a fall-through annotation needs to go
before the first case.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the xoreos-git mailing list