[xoreos-git] [xoreos/phaethon] e54e9f: COMMON: Change parseString() to not read potential...

Tue Jul 24 10:47:28 CEST 2018

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/phaethon
  Commit: e54e9f9a02a06b4cdde70e329872129467947d9b
      https://github.com/xoreos/phaethon/commit/e54e9f9a02a06b4cdde70e329872129467947d9b
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-02 (Mon, 02 Jul 2018)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Change parseString() to not read potentially undefined values

Instead of copying the old value of parameter and writing it back on
error, parseString now parses into a new variable and copies on
success.

This should shut up Coverity Scan complaining about reading undefined
values.

  Commit: 4eab35912ee3cbb20a0aecba504eba772a743010
      https://github.com/xoreos/phaethon/commit/4eab35912ee3cbb20a0aecba504eba772a743010
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M src/common/rules.mk

  Log Message:
  -----------
  BUILD: Add common/binsearch.h to the rules.mk

It won't be distributed otherwise.

  Commit: eca6f36aa114fc90f2f6e2688cf1010b42c776d2
      https://github.com/xoreos/phaethon/commit/eca6f36aa114fc90f2f6e2688cf1010b42c776d2
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M rules.mk

  Log Message:
  -----------
  BUILD: Add cmake/CMakeUninstall.cmake to the rules.mk

It won't be distributed otherwise.

  Commit: 6b6c57b44d86fd371ac2749cafcf7434b6375269
      https://github.com/xoreos/phaethon/commit/6b6c57b44d86fd371ac2749cafcf7434b6375269
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M dists/fedora/phaethon.spec

  Log Message:
  -----------
  DIST: Package the manpage in the Fedora spec file

  Commit: 9d846838f94b224881fc3bd02be2864d49c05bb8
      https://github.com/xoreos/phaethon/commit/9d846838f94b224881fc3bd02be2864d49c05bb8
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M CMakeLists.txt
    M ChangeLog
    M Doxyfile
    A NEWS.md
    M configure.ac
    M dists/arch/PKGBUILD
    M dists/debian/changelog
    M dists/fedora/phaethon.spec
    M dists/win32/phaethon.rc
    M doc/rules.mk
    M src/version/version.cpp

  Log Message:
  -----------
  RELEASE: This is version 0.0.5

  Commit: 77a5d3d76e0a345ef66e6f1d5bd0b1a3244e61a5
      https://github.com/xoreos/phaethon/commit/77a5d3d76e0a345ef66e6f1d5bd0b1a3244e61a5
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-04 (Wed, 04 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp

  Log Message:
  -----------
  GUI: Use item name as default file name when saving

  Commit: 85c633bee835bd26d489bd5f67060914489574b3
      https://github.com/xoreos/phaethon/commit/85c633bee835bd26d489bd5f67060914489574b3
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-04 (Wed, 04 Jul 2018)

  Changed paths:
    M dists/win32/phaethon.rc

  Log Message:
  -----------
  DIST: Mark version in Windows resources as "+git"

[ci skip]

  Commit: b83ffe8824f4463eae265fd569f75ed5079e1aa4
      https://github.com/xoreos/phaethon/commit/b83ffe8824f4463eae265fd569f75ed5079e1aa4
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-04 (Wed, 04 Jul 2018)

  Changed paths:
    M src/gui/panelpreviewtable.cpp
    M src/gui/panelpreviewtable.h

  Log Message:
  -----------
  GUI: Put PanelPreviewTable::_model into a ScopedPtr

Plugging a memory leak.

  Commit: a8d4155a767abd2543c7f0caf89cb21307d0a5a0
      https://github.com/xoreos/phaethon/commit/a8d4155a767abd2543c7f0caf89cb21307d0a5a0
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-04 (Wed, 04 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp

  Log Message:
  -----------
  GUI: Properly reparent widgets and delete items when changing panels

This fixes a memory leak.
Also closes issue #23.

  Commit: b7e18bde808bacd0bbc6f691ce967df08daeaf45
      https://github.com/xoreos/phaethon/commit/b7e18bde808bacd0bbc6f691ce967df08daeaf45
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp

  Log Message:
  -----------
  GUI: Use a consistent code style for QFileDialog::getSaveFileName

  Commit: 834bdc9c68c947dc474d31f5034e0efbfd97fee4
      https://github.com/xoreos/phaethon/commit/834bdc9c68c947dc474d31f5034e0efbfd97fee4
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp

  Log Message:
  -----------
  GUI: Use item name with replaced extension for TGA export

  Commit: 52c1e750650f10fb483517d1a585a162904232f0
      https://github.com/xoreos/phaethon/commit/52c1e750650f10fb483517d1a585a162904232f0
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp

  Log Message:
  -----------
  GUI: Fix file type filters when saving

  Commit: 4b8e79d710fe3024af377eb76e9e6eec93c22cd3
      https://github.com/xoreos/phaethon/commit/4b8e79d710fe3024af377eb76e9e6eec93c22cd3
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M src/gui/resourcetree.cpp

  Log Message:
  -----------
  GUI: Remove needless string conversion

  Commit: 67aa6f8ed0b4da1b3a42e8834f0513c7fe739e36
      https://github.com/xoreos/phaethon/commit/67aa6f8ed0b4da1b3a42e8834f0513c7fe739e36
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-08 (Sun, 08 Jul 2018)

  Changed paths:
    M src/aurora/keyfile.cpp
    M src/aurora/keyfile.h
    M src/gui/resourcetree.cpp
    M src/gui/resourcetree.h

  Log Message:
  -----------
  GUI: Allow opening BIF files directly

  Commit: 295c2cff746f2aa1b16a4ae6aa755d2138a4cf9b
      https://github.com/xoreos/phaethon/commit/295c2cff746f2aa1b16a4ae6aa755d2138a4cf9b
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-15 (Sun, 15 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp
    M src/gui/mainwindow.h
    A src/gui/panelbase.cpp
    A src/gui/panelbase.h
    A src/gui/panelmanager.cpp
    A src/gui/panelmanager.h
    M src/gui/panelpreviewempty.cpp
    M src/gui/panelpreviewempty.h
    M src/gui/panelpreviewimage.cpp
    M src/gui/panelpreviewimage.h
    M src/gui/panelpreviewsound.cpp
    M src/gui/panelpreviewsound.h
    M src/gui/panelpreviewtable.cpp
    M src/gui/panelpreviewtable.h
    M src/gui/panelpreviewtext.cpp
    M src/gui/panelpreviewtext.h
    M src/gui/rules.mk

  Log Message:
  -----------
  GUI: Use new manager class for panels

  Commit: e1d2bd74a21b2b3c8118ee7b42d0369d33c66345
      https://github.com/xoreos/phaethon/commit/e1d2bd74a21b2b3c8118ee7b42d0369d33c66345
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-15 (Sun, 15 Jul 2018)

  Changed paths:
    M ChangeLog

  Log Message:
  -----------
  DOCS: Mention opening BIF files in the ChangeLog

[ci skip]

  Commit: cfe292cb40e3d9205acb347a79d80ec6c43c5ede
      https://github.com/xoreos/phaethon/commit/cfe292cb40e3d9205acb347a79d80ec6c43c5ede
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-16 (Mon, 16 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp
    M src/gui/panelmanager.cpp
    M src/gui/panelpreviewtable.cpp
    M src/gui/panelpreviewtext.cpp
    M src/gui/resourcetree.cpp
    M src/gui/resourcetreeitem.cpp

  Log Message:
  -----------
  GUI: Replace 0 with nullptr

  Commit: e0fa81be4b1aad17ac2f4e9dab31fafe78d20c2b
      https://github.com/xoreos/phaethon/commit/e0fa81be4b1aad17ac2f4e9dab31fafe78d20c2b
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-17 (Tue, 17 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp
    M src/gui/mainwindow.h
    M src/gui/panelmanager.cpp
    M src/gui/panelmanager.h
    M src/gui/panelpreviewimage.cpp
    M src/gui/panelpreviewimage.h
    M src/gui/panelpreviewsound.h
    M src/gui/panelpreviewtable.h
    M src/gui/panelpreviewtext.cpp
    M src/gui/panelpreviewtext.h
    M src/gui/panelresourceinfo.h
    M src/gui/resourcetree.cpp
    M src/gui/resourcetree.h
    M src/gui/resourcetreeitem.cpp
    M src/gui/resourcetreeitem.h
    M src/gui/statusbar.h

  Log Message:
  -----------
  GUI: Initialise class and struct members in the headers

  Commit: 09991a552402fc3c5e0d3c28698d7fd856f7643b
      https://github.com/xoreos/phaethon/commit/09991a552402fc3c5e0d3c28698d7fd856f7643b
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-19 (Thu, 19 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp

  Log Message:
  -----------
  GUI: Fix panel not being set to empty on archives and directories

  Commit: c51aa898dcc6e54ad1d3d46aade69b43e0be0016
      https://github.com/xoreos/phaethon/commit/c51aa898dcc6e54ad1d3d46aade69b43e0be0016
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-19 (Thu, 19 Jul 2018)

  Changed paths:
    M src/gui/mainwindow.cpp
    M src/gui/mainwindow.h
    M src/gui/panelmanager.cpp
    M src/gui/panelpreviewimage.cpp
    M src/gui/panelpreviewsound.cpp
    M src/gui/panelpreviewtable.cpp
    M src/gui/panelpreviewtable.h
    M src/gui/panelpreviewtext.cpp
    M src/gui/resourcetree.cpp
    M src/gui/resourcetree.h
    M src/gui/resourcetreeitem.cpp

  Log Message:
  -----------
  GUI: Replace ScopedPtr with std::unique_ptr

  Commit: 80a46bd41ffa50791ebddf139c0b1c6bd3ee9def
      https://github.com/xoreos/phaethon/commit/80a46bd41ffa50791ebddf139c0b1c6bd3ee9def
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/common/deflate.cpp
    M src/common/deflate.h

  Log Message:
  -----------
  COMMON: Add the possibility to deflate without knowing the output size

This is needed for scaleform gfx files

  Commit: e518ae272522bf84f85bfcc8e94179a643def61d
      https://github.com/xoreos/phaethon/commit/e518ae272522bf84f85bfcc8e94179a643def61d
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M tests/common/deflate.cpp

  Log Message:
  -----------
  TESTS: Add a unit test for deflate without output size

  Commit: 197f5353cc27e3a72a58d7ee1f60cfa52f02d5dd
      https://github.com/xoreos/phaethon/commit/197f5353cc27e3a72a58d7ee1f60cfa52f02d5dd
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/common/deflate.cpp

  Log Message:
  -----------
  COMMON: Use Z_SYNC_FLUSH instead of Z_FULL_FLUSH in inflate()

Z_FULL_FLUSH isn't a valid option for inflate(). It's only defined for
deflate().

  Commit: 802300c9c446804fbc4c1cf38833d9192763b236
      https://github.com/xoreos/phaethon/commit/802300c9c446804fbc4c1cf38833d9192763b236
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/common/deflate.cpp
    M src/common/deflate.h
    M tests/common/deflate.cpp

  Log Message:
  -----------
  COMMON: Add decompressDeflateChunk()

Useful for decompressing and reassembling files that have been split
into individually zlib-compressed chunks.

  Commit: 6cae53623449513c1b965754a1668ba8e3229147
      https://github.com/xoreos/phaethon/commit/6cae53623449513c1b965754a1668ba8e3229147
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/common/strutil.cpp
    M src/common/strutil.h
    M tests/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Add searchBackwards(), searching for bytes in a stream

  Commit: 9bcb5ae82ebad7c528afe0586415c214b20d6e76
      https://github.com/xoreos/phaethon/commit/9bcb5ae82ebad7c528afe0586415c214b20d6e76
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/common/zipfile.cpp
    M src/common/zipfile.h

  Log Message:
  -----------
  COMMON: Use searchBackwards() in ZipFile

  Commit: 73c75ff74f97cd82afbf027b818afa55b77370ec
      https://github.com/xoreos/phaethon/commit/73c75ff74f97cd82afbf027b818afa55b77370ec
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/aurora/types.h
    M src/aurora/util.cpp

  Log Message:
  -----------
  AURORA: Add file types found in Aspyr's Android port of Jade Empire

  Commit: 69da841e3057147895ec9bf5635237fafe1565d7
      https://github.com/xoreos/phaethon/commit/69da841e3057147895ec9bf5635237fafe1565d7
  Author: michaelpm54 <39412876+michaelpm54 at users.noreply.github.com>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/gui/resourcetree.cpp
    M src/gui/resourcetree.h

  Log Message:
  -----------
  GUI: Replace PtrMap with std::map and std::unique_ptr

Compare: https://github.com/xoreos/phaethon/compare/154913657b6c...69da841e3057
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.