[xoreos-git] [xoreos/xoreos] 884963: COMMON: Use boost::atomic to signal thread running...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: 884963e6a05dabb76764a58adaa7c1a922f0d7cd
      https://github.com/xoreos/xoreos/commit/884963e6a05dabb76764a58adaa7c1a922f0d7cd
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-08 (Sun, 08 Jul 2018)

  Changed paths:
    M src/common/thread.cpp
    M src/common/thread.h
    M src/events/requests.cpp
    M src/graphics/aurora/animationthread.cpp
    M src/sound/sound.cpp

  Log Message:
  -----------
  COMMON: Use boost::atomic to signal thread running and killing

Otherwise, this might be prone to race conditions. volatile isn't the
correct way to deal with this, either.

We can't really force a thread to die, either. SDL1 had a function for
that, but it was not portable and unreliable, so they removed it.

We can, however, detect that the thread is still running and issue a
warning.


  Commit: 347fe7be77223430dc8bb536d80ccebbdd3b7d97
      https://github.com/xoreos/xoreos/commit/347fe7be77223430dc8bb536d80ccebbdd3b7d97
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-08 (Sun, 08 Jul 2018)

  Changed paths:
    M src/graphics/graphics.cpp

  Log Message:
  -----------
  GRAPHICS: Name the animation thread


  Commit: 7001ae11df08f997b116ca751129495b517ba279
      https://github.com/xoreos/xoreos/commit/7001ae11df08f997b116ca751129495b517ba279
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-08 (Sun, 08 Jul 2018)

  Changed paths:
    M src/graphics/graphics.cpp

  Log Message:
  -----------
  GRAPHICS: Throw when the animation thread can't be created


Compare: https://github.com/xoreos/xoreos/compare/ff30acfe0010...7001ae11df08
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.