[xoreos-git] [xoreos/xoreos] c65a2b: KOTOR: Remove unused variable Version::_version

GitHub noreply at github.com
Mon Jul 2 12:11:38 CEST 2018


  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/xoreos
  Commit: c65a2bbd1bc8afbf7964c2193ce4fc0ba33af8a6
      https://github.com/xoreos/xoreos/commit/c65a2bbd1bc8afbf7964c2193ce4fc0ba33af8a6
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-02 (Mon, 02 Jul 2018)

  Changed paths:
    M src/engines/kotor/version.h

  Log Message:
  -----------
  KOTOR: Remove unused variable Version::_version

This fixes Coverity Scan issue #1393769.


  Commit: 8e434cc4cd1bf50e69fa36f4226ea9e115f93424
      https://github.com/xoreos/xoreos/commit/8e434cc4cd1bf50e69fa36f4226ea9e115f93424
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-07-02 (Mon, 02 Jul 2018)

  Changed paths:
    M src/common/strutil.cpp

  Log Message:
  -----------
  COMMON: Change parseString() to not read potentially undefined values

Instead of copying the old value of parameter and writing it back on
error, parseString now parses into a new variable and copies on
success.

This should shut up Coverity Scan complaining about reading undefined
values.


Compare: https://github.com/xoreos/xoreos/compare/d418be16d307...8e434cc4cd1b
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the xoreos-git mailing list