[xoreos-git] [xoreos/xoreos] 64659a: GRAPHICS: Don't use std::vector<>::data()

Tue Feb 13 15:01:38 CET 2018

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/xoreos
  Commit: 64659a6c2127d0e4e59a1beec0c82fac367c4486
      https://github.com/xoreos/xoreos/commit/64659a6c2127d0e4e59a1beec0c82fac367c4486
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-24 (Sun, 24 Dec 2017)

  Changed paths:
    M src/graphics/aurora/animation.cpp
    M src/graphics/aurora/model_kotor.cpp

  Log Message:
  -----------
  GRAPHICS: Don't use std::vector<>::data()

It's a C++11 method, and we're still C++03.

  Commit: 1609a1dc296262d6c07a60d3386bc2d9bf0e2c33
      https://github.com/xoreos/xoreos/commit/1609a1dc296262d6c07a60d3386bc2d9bf0e2c33
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-24 (Sun, 24 Dec 2017)

  Changed paths:
    M src/engines/kotor/creature.cpp

  Log Message:
  -----------
  GRAPHICS: Don't use std::map<>::at()

It's a C++11 method, and we're still C++03.

  Commit: a1f2851f870e68c3ce7a5f75adc054638196ba65
      https://github.com/xoreos/xoreos/commit/a1f2851f870e68c3ce7a5f75adc054638196ba65
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-24 (Sun, 24 Dec 2017)

  Changed paths:
    M src/engines/aurora/gui.cpp
    M src/engines/aurora/gui.h

  Log Message:
  -----------
  ENGINES: Split hiding and re-showing self in GUI::sub()

Only hiding when we're re-showing the parent GUI breaks the main menu
in NWN.

  Commit: 0ccc0bba088b7d2f6c5154c6abf52ed97d9ffb59
      https://github.com/xoreos/xoreos/commit/0ccc0bba088b7d2f6c5154c6abf52ed97d9ffb59
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-27 (Wed, 27 Dec 2017)

  Changed paths:
    M AUTHORS

  Log Message:
  -----------
  DOCS: Add Vsevolod Kremianskii's nickname to the AUTHORS file

  Commit: 45af50a2f8bb381e41a92e4c5c50884a28c5a6e1
      https://github.com/xoreos/xoreos/commit/45af50a2f8bb381e41a92e4c5c50884a28c5a6e1
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-27 (Wed, 27 Dec 2017)

  Changed paths:
    M src/graphics/images/dds.cpp
    M src/graphics/images/dds.h
    M src/graphics/images/sbm.h
    M src/graphics/images/tga.h
    M src/graphics/images/tpc.h
    M src/graphics/images/txb.h

  Log Message:
  -----------
  GRAPHICS: Document which games use the different image formats

  Commit: aabf7114103ff46bafdf8712eeeff6c04eaea55a
      https://github.com/xoreos/xoreos/commit/aabf7114103ff46bafdf8712eeeff6c04eaea55a
  Author: patrick <nostritius at googlemail.com>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/engines/kotor/creature.cpp

  Log Message:
  -----------
  KOTOR: Read creatures gender on loading it

  Commit: 4f1f7dfdbe120633e59bac2c3c78e02927c5c6b3
      https://github.com/xoreos/xoreos/commit/4f1f7dfdbe120633e59bac2c3c78e02927c5c6b3
  Author: patrick <nostritius at googlemail.com>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M src/engines/kotor/types.h

  Log Message:
  -----------
  KOTOR: Add races according to nwscript.nss

  Commit: f487932d0c65193829ed51d174f1480407f92e1f
      https://github.com/xoreos/xoreos/commit/f487932d0c65193829ed51d174f1480407f92e1f
  Author: patrick <nostritius at googlemail.com>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M src/engines/kotor/types.h

  Log Message:
  -----------
  KOTOR: Add subraces according to nwscript.nss

  Commit: 372953e4196fca6cb7fcdad685a96c6386b7401a
      https://github.com/xoreos/xoreos/commit/372953e4196fca6cb7fcdad685a96c6386b7401a
  Author: patrick <nostritius at googlemail.com>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M src/engines/kotor/creature.cpp
    M src/engines/kotor/creature.h

  Log Message:
  -----------
  KOTOR: Add race loading and getters for creature class

  Commit: 8ae8b35c60a40d66fc9ce6443065bd223e568c82
      https://github.com/xoreos/xoreos/commit/8ae8b35c60a40d66fc9ce6443065bd223e568c82
  Author: patrick <nostritius at googlemail.com>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor/script/functions.h
    M src/engines/kotor/script/functions_creatures.cpp

  Log Message:
  -----------
  KOTOR: Add race nwscript functions

  Commit: 5d1e72f423726bac762b3692350d00284f7027a1
      https://github.com/xoreos/xoreos/commit/5d1e72f423726bac762b3692350d00284f7027a1
  Author: patrick <nostritius at googlemail.com>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M src/engines/kotor/creature.cpp

  Log Message:
  -----------
  KOTOR: Initialize pc as human with no sub race

  Commit: 1361ea7e2ba142ce204372adfb339ca95e48c111
      https://github.com/xoreos/xoreos/commit/1361ea7e2ba142ce204372adfb339ca95e48c111
  Author: patrick <nostritius at googlemail.com>
  Date:   2017-12-29 (Fri, 29 Dec 2017)

  Changed paths:
    M src/engines/aurora/gui.cpp

  Log Message:
  -----------
  AURORA: Prevent the overwrite of a none-zero by a zero return code

It is possible that a child gui overwrites a none-zero return code of the parent gui. This should prevent it.

  Commit: 0ca1e417a57aed277fb73592cdfc8cf6f47357ef
      https://github.com/xoreos/xoreos/commit/0ca1e417a57aed277fb73592cdfc8cf6f47357ef
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-04 (Thu, 04 Jan 2018)

  Changed paths:
    M src/engines/kotor/creature.cpp

  Log Message:
  -----------
  KOTOR: Fix subrace loading bug

  Commit: 2a9506ba948b0156f229e98f75399dc55dac01a4
      https://github.com/xoreos/xoreos/commit/2a9506ba948b0156f229e98f75399dc55dac01a4
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-15 (Mon, 15 Jan 2018)

  Changed paths:
    M src/engines/kotor/gui/widgets/kotorwidget.cpp

  Log Message:
  -----------
  KOTOR: Fix that border dimension misplaced widgets bug

The one widget which was misplaced, had weird dimension values, while
not having an actual border. This commit prevents a widget from
rearranging itself with border dimensions if it actually has no
border.

  Commit: 38c0b31faefe997a59a3de52004d650cdc939fa9
      https://github.com/xoreos/xoreos/commit/38c0b31faefe997a59a3de52004d650cdc939fa9
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-19 (Fri, 19 Jan 2018)

  Changed paths:
    M src/engines/jade/gui/main/main.cpp

  Log Message:
  -----------
  JADE: Add credits movie to main menu

  Commit: 17eef98393f790b52c8ea88ddabb8db705d07cb2
      https://github.com/xoreos/xoreos/commit/17eef98393f790b52c8ea88ddabb8db705d07cb2
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-19 (Fri, 19 Jan 2018)

  Changed paths:
    M src/engines/kotor/creature.cpp
    M src/engines/kotor/creature.h

  Log Message:
  -----------
  KOTOR: Improve the creature level representation

The order of the levels are actually relevant for certain nwscript functions. This commit tries to take care of this.

  Commit: 11d45cf06ae39149b34a0cfc44488d3e98f5f75e
      https://github.com/xoreos/xoreos/commit/11d45cf06ae39149b34a0cfc44488d3e98f5f75e
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-19 (Fri, 19 Jan 2018)

  Changed paths:
    M src/engines/kotor/creature.cpp
    M src/engines/kotor/creature.h

  Log Message:
  -----------
  KOTOR: Add getLevelByPosition and getClassByPosition methods

These two methods return the actual level and class regarding their position in the level vector.

  Commit: b1747fb3ff7d84311f88cd85458294a4ddd6b7af
      https://github.com/xoreos/xoreos/commit/b1747fb3ff7d84311f88cd85458294a4ddd6b7af
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-19 (Fri, 19 Jan 2018)

  Changed paths:
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor/script/functions.h
    M src/engines/kotor/script/functions_creatures.cpp

  Log Message:
  -----------
  KOTOR: Add GetClassByPosition and GetLevelByPosition as nwscript functions

  Commit: 33635c48352feef01301b29803ec36d43904de26
      https://github.com/xoreos/xoreos/commit/33635c48352feef01301b29803ec36d43904de26
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/creature.cpp

  Log Message:
  -----------
  KOTOR: Add class level initial loading for creatures

  Commit: 1a8387b5bb60fdd62bbd273aa1750c2196263a13
      https://github.com/xoreos/xoreos/commit/1a8387b5bb60fdd62bbd273aa1750c2196263a13
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    A src/engines/jade/gui/options/rules.mk
    M src/engines/jade/gui/rules.mk

  Log Message:
  -----------
  JADE: Add rules.mk for option menus

  Commit: b4b289bbe4922633135b3685aaba695c02cfe597
      https://github.com/xoreos/xoreos/commit/b4b289bbe4922633135b3685aaba695c02cfe597
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    A src/engines/jade/gui/options/audio.cpp
    A src/engines/jade/gui/options/audio.h
    M src/engines/jade/gui/options/rules.mk

  Log Message:
  -----------
  JADE: Add basic audio options menu

  Commit: 9b0e8e400ac5af1824c4e502bc2d9af2df1f68f9
      https://github.com/xoreos/xoreos/commit/9b0e8e400ac5af1824c4e502bc2d9af2df1f68f9
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/jade/gui/options/rules.mk
    A src/engines/jade/gui/options/video.cpp
    A src/engines/jade/gui/options/video.h

  Log Message:
  -----------
  JADE: Add basic graphic options menu

  Commit: 95e9fd5d404d88bd0f1d86287ef532f78eadb028
      https://github.com/xoreos/xoreos/commit/95e9fd5d404d88bd0f1d86287ef532f78eadb028
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    A src/engines/jade/gui/options/diff.cpp
    A src/engines/jade/gui/options/diff.h
    M src/engines/jade/gui/options/rules.mk

  Log Message:
  -----------
  JADE: Add basic difficulty options menu

  Commit: b7e19f0a2c24c3c6912c98f2ce8ed0be3b67a574
      https://github.com/xoreos/xoreos/commit/b7e19f0a2c24c3c6912c98f2ce8ed0be3b67a574
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    A src/engines/jade/gui/options/feed.cpp
    A src/engines/jade/gui/options/feed.h
    M src/engines/jade/gui/options/rules.mk

  Log Message:
  -----------
  JADE: Add basic game info menu

  Commit: 73524929b780da6ca6c8b4e7c7133e86c66beff6
      https://github.com/xoreos/xoreos/commit/73524929b780da6ca6c8b4e7c7133e86c66beff6
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    A src/engines/jade/gui/options/control.cpp
    A src/engines/jade/gui/options/control.h
    M src/engines/jade/gui/options/rules.mk

  Log Message:
  -----------
  JADE: Add basic control options menu

  Commit: cc7188e01be8927d2b00d7a4f3fd96406f2f4201
      https://github.com/xoreos/xoreos/commit/cc7188e01be8927d2b00d7a4f3fd96406f2f4201
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    A src/engines/jade/gui/main/options.cpp
    A src/engines/jade/gui/main/options.h
    M src/engines/jade/gui/main/rules.mk

  Log Message:
  -----------
  JADE: Add main options menu

  Commit: 2a045945a21ada0a6c43da2f883ab94a0b48d0f0
      https://github.com/xoreos/xoreos/commit/2a045945a21ada0a6c43da2f883ab94a0b48d0f0
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/jade/gui/main/options.cpp

  Log Message:
  -----------
  JADE: Add credits movie to main options menu

  Commit: af924c29f7b86253b6838c754fbf3a30c1f40ca4
      https://github.com/xoreos/xoreos/commit/af924c29f7b86253b6838c754fbf3a30c1f40ca4
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/jade/gui/main/main.cpp
    M src/engines/jade/gui/main/main.h

  Log Message:
  -----------
  JADE: Add options menu to main menu

  Commit: 1990281879f614a533056f2a6e9c487f90b9c471
      https://github.com/xoreos/xoreos/commit/1990281879f614a533056f2a6e9c487f90b9c471
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/gui/ingame/hud.cpp
    M src/engines/kotor/gui/ingame/hud.h
    M src/engines/kotor/gui/ingame/ingame.cpp
    M src/engines/kotor/gui/ingame/ingame.h
    M src/engines/kotor/gui/ingame/menu.cpp
    M src/engines/kotor/gui/ingame/menu.h
    M src/engines/kotor/gui/ingame/menu_map.cpp
    M src/engines/kotor/gui/ingame/menu_map.h
    M src/engines/kotor/module.cpp
    M src/engines/kotor/module.h

  Log Message:
  -----------
  KOTOR: Enable the changing of the return to hideout/ebon hawk strings

  Commit: aa12dd1de018ecc40199894af33d377945e8d0b9
      https://github.com/xoreos/xoreos/commit/aa12dd1de018ecc40199894af33d377945e8d0b9
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor/script/functions.h
    M src/engines/kotor/script/functions_module.cpp

  Log Message:
  -----------
  KOTOR: Add nwscript function SetReturnStrref

  Commit: 8c2683986ec5eecca6ed630f276d3b41ad6bb2ac
      https://github.com/xoreos/xoreos/commit/8c2683986ec5eecca6ed630f276d3b41ad6bb2ac
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/object.cpp
    M src/engines/kotor/object.h

  Log Message:
  -----------
  KOTOR: Add hitpoints to every object

  Commit: ae0237e90a32fa6d08f419a3ac598bde02dc2e37
      https://github.com/xoreos/xoreos/commit/ae0237e90a32fa6d08f419a3ac598bde02dc2e37
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/creature.cpp

  Log Message:
  -----------
  KOTOR: Add hitpoint data loading for creatures

  Commit: b9d2385e664685fa906b789019d4015692e1602e
      https://github.com/xoreos/xoreos/commit/b9d2385e664685fa906b789019d4015692e1602e
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/placeable.cpp

  Log Message:
  -----------
  KOTOR: Add hitpoint data loading for placeables

  Commit: 202fb27b0c79c50cb7ac2cd408e892a44be3c9e9
      https://github.com/xoreos/xoreos/commit/202fb27b0c79c50cb7ac2cd408e892a44be3c9e9
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/script/function_tables.h
    M src/engines/kotor/script/functions.h
    M src/engines/kotor/script/functions_object.cpp

  Log Message:
  -----------
  KOTOR: Add hitpoint specific nwscript functions

  Commit: a5c1a6041e7a17e98537f09af4899944479012fa
      https://github.com/xoreos/xoreos/commit/a5c1a6041e7a17e98537f09af4899944479012fa
  Author: patrick <nostritius at googlemail.com>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M src/engines/kotor/script/functions_object.cpp

  Log Message:
  -----------
  KOTOR: Correct setMaxHitPoints exception string

  Commit: 9b1120552fbf92de6ebb9a0444010e293fc00b31
      https://github.com/xoreos/xoreos/commit/9b1120552fbf92de6ebb9a0444010e293fc00b31
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-10 (Sat, 10 Feb 2018)

  Changed paths:
    M m4/boost.m4

  Log Message:
  -----------
  BUILD: Extend boost.m4 to recognize clang 3.0 - 5.0

  Commit: eeef8d5472e8388086059aa610928bfb70d6e65a
      https://github.com/xoreos/xoreos/commit/eeef8d5472e8388086059aa610928bfb70d6e65a
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-10 (Sat, 10 Feb 2018)

  Changed paths:
    M m4/boost.m4

  Log Message:
  -----------
  BUILD: Extend boost.m4 to recognize gcc 7.3 and 8.0

  Commit: 9d416d3cad3dc37b0bbd24271387b36e30fc02e0
      https://github.com/xoreos/xoreos/commit/9d416d3cad3dc37b0bbd24271387b36e30fc02e0
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M lua/ldebug.cpp
    M lua/lstrlib.cpp
    M lua/ltable.cpp

  Log Message:
  -----------
  LUA: Use "fallthrough" switch comments gcc understands

In preparation of enabling warnings for unmarked fallthroughs.

  Commit: 84197c2e2d92c2d2e3e55dc46d5831ee5010c272
      https://github.com/xoreos/xoreos/commit/84197c2e2d92c2d2e3e55dc46d5831ee5010c272
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M src/aurora/lua/util.cpp

  Log Message:
  -----------
  AURORA: Mark intentional fallthrough in switch statements

  Commit: 89af1c134283a52a51eca43117c3297c77e843a2
      https://github.com/xoreos/xoreos/commit/89af1c134283a52a51eca43117c3297c77e843a2
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M src/sound/decoders/wma.cpp

  Log Message:
  -----------
  SOUND: Mark intentional fallthrough in switch statements

These are instances of Duff's device, even.

  Commit: 68732f829b5cce08e4ed5972fc651f1ce2ea7a6f
      https://github.com/xoreos/xoreos/commit/68732f829b5cce08e4ed5972fc651f1ce2ea7a6f
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M src/video/bink.cpp

  Log Message:
  -----------
  VIDEO: Mark intentional fallthrough in switch statements

  Commit: dd969633fa1f77863d0fdcbebd7e6dddce9da3a3
      https://github.com/xoreos/xoreos/commit/dd969633fa1f77863d0fdcbebd7e6dddce9da3a3
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M CMakeLists.txt
    M configure.ac

  Log Message:
  -----------
  BUILD: Add the -Wimplicit-fallthrough warning flag

This warns about implicit (unmarked) fallthroughs in switch
statements. So now, all fallthroughs will have to be marked with a
"// Fallthrough" comment, to make it very obvious that the fallthrough
is intentional and not just an oversight.

  Commit: b0ac9c14df8469a7e7896b954c1312c79a487932
      https://github.com/xoreos/xoreos/commit/b0ac9c14df8469a7e7896b954c1312c79a487932
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M CMakeLists.txt
    M configure.ac

  Log Message:
  -----------
  BUILD: Add the -Wduplicated-branches warning flag

-Wduplicated-branches warns when an if-else has identical branches.

  Commit: c131d384679615f6a87100ff6512558873e6dc49
      https://github.com/xoreos/xoreos/commit/c131d384679615f6a87100ff6512558873e6dc49
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M AUTHORS
    M dists/debian/copyright
    M dists/macosx/Info.plist
    M dists/win32/xoreos.rc
    M src/version/version.cpp

  Log Message:
  -----------
  DOCS: Update copyright year to 2018

Happy (belated) new year! :)

Compare: https://github.com/xoreos/xoreos/compare/376952e108b1...c131d3846796