[xoreos-git] [xoreos/xoreos] 9d416d: LUA: Use "fallthrough" switch comments gcc underst...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: 9d416d3cad3dc37b0bbd24271387b36e30fc02e0
      https://github.com/xoreos/xoreos/commit/9d416d3cad3dc37b0bbd24271387b36e30fc02e0
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M lua/ldebug.cpp
    M lua/lstrlib.cpp
    M lua/ltable.cpp

  Log Message:
  -----------
  LUA: Use "fallthrough" switch comments gcc understands

In preparation of enabling warnings for unmarked fallthroughs.


  Commit: 84197c2e2d92c2d2e3e55dc46d5831ee5010c272
      https://github.com/xoreos/xoreos/commit/84197c2e2d92c2d2e3e55dc46d5831ee5010c272
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M src/aurora/lua/util.cpp

  Log Message:
  -----------
  AURORA: Mark intentional fallthrough in switch statements


  Commit: 89af1c134283a52a51eca43117c3297c77e843a2
      https://github.com/xoreos/xoreos/commit/89af1c134283a52a51eca43117c3297c77e843a2
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M src/sound/decoders/wma.cpp

  Log Message:
  -----------
  SOUND: Mark intentional fallthrough in switch statements

These are instances of Duff's device, even.


  Commit: 68732f829b5cce08e4ed5972fc651f1ce2ea7a6f
      https://github.com/xoreos/xoreos/commit/68732f829b5cce08e4ed5972fc651f1ce2ea7a6f
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M src/video/bink.cpp

  Log Message:
  -----------
  VIDEO: Mark intentional fallthrough in switch statements


  Commit: dd969633fa1f77863d0fdcbebd7e6dddce9da3a3
      https://github.com/xoreos/xoreos/commit/dd969633fa1f77863d0fdcbebd7e6dddce9da3a3
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M CMakeLists.txt
    M configure.ac

  Log Message:
  -----------
  BUILD: Add the -Wimplicit-fallthrough warning flag

This warns about implicit (unmarked) fallthroughs in switch
statements. So now, all fallthroughs will have to be marked with a
"// Fallthrough" comment, to make it very obvious that the fallthrough
is intentional and not just an oversight.


  Commit: b0ac9c14df8469a7e7896b954c1312c79a487932
      https://github.com/xoreos/xoreos/commit/b0ac9c14df8469a7e7896b954c1312c79a487932
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2018-02-13 (Tue, 13 Feb 2018)

  Changed paths:
    M CMakeLists.txt
    M configure.ac

  Log Message:
  -----------
  BUILD: Add the -Wduplicated-branches warning flag

-Wduplicated-branches warns when an if-else has identical branches.


Compare: https://github.com/xoreos/xoreos/compare/eeef8d5472e8...b0ac9c14df84