[xoreos-git] [xoreos/xoreos] 1e1488: KOTOR: Make sure WidgetProgressbar doesn't divide ...

[GitHub]

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/xoreos/xoreos
  Commit: 1e14889b5eb71658fc961e2ea2f635c3af606992
      https://github.com/xoreos/xoreos/commit/1e14889b5eb71658fc961e2ea2f635c3af606992
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/progressbar.cpp

  Log Message:
  -----------
  KOTOR: Make sure WidgetProgressbar doesn't divide by zero

We now also try to make "sense" of nonsensical curValue/maxValue
relations.

This fixes Coverity Scan issue #1383486.


  Commit: 36fd2a03b395f7bb6c04ae510967e30e709cae63
      https://github.com/xoreos/xoreos/commit/36fd2a03b395f7bb6c04ae510967e30e709cae63
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/progressbar.cpp

  Log Message:
  -----------
  KOTOR: Initialize WidgetProgressbar member variables

This fixes Coverity Scan issue #1383506.


  Commit: 30bba59e60b3a4082c772b5da0c03a22e23f8658
      https://github.com/xoreos/xoreos/commit/30bba59e60b3a4082c772b5da0c03a22e23f8658
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/listbox.cpp

  Log Message:
  -----------
  KOTOR: Fix a minor style issue: newline before opening braces


  Commit: ff15aa7abba84b1acceef9e84514d51d95eb51f7
      https://github.com/xoreos/xoreos/commit/ff15aa7abba84b1acceef9e84514d51d95eb51f7
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/listbox.cpp

  Log Message:
  -----------
  KOTOR: Initialize WidgetListBox::_protoItem

This fixes Coverity Scan issue #1383487.


  Commit: 031dbe049bf29b66bfe52efae9517be7ed65884f
      https://github.com/xoreos/xoreos/commit/031dbe049bf29b66bfe52efae9517be7ed65884f
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/listbox.cpp

  Log Message:
  -----------
  KOTOR: Throw on WidgetListBox::createItem() with missing _protoItem

Otherwise, the code would segfault in that case.


  Commit: 108da826fe9ce68498fa7702f88c6e058fbe8b9a
      https://github.com/xoreos/xoreos/commit/108da826fe9ce68498fa7702f88c6e058fbe8b9a
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/chargen/classselection.cpp

  Log Message:
  -----------
  KOTOR: Initialize ClassSelectionMenu::_hoveredButton

This fixes Coverity Scan issue #1383495.


  Commit: 934ae9051e10cbebe034f87e9a803c605e5d3759
      https://github.com/xoreos/xoreos/commit/934ae9051e10cbebe034f87e9a803c605e5d3759
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/graphics/aurora/borderquad.h

  Log Message:
  -----------
  GRAPHICS: Remove BorderQuad::_z

It was completely unused; not even initialized.

This fixes Coverity Scan issue #1383491.


  Commit: 0b1b388c2c9bfa27c9a8e2b604b6c6b6cd966fab
      https://github.com/xoreos/xoreos/commit/0b1b388c2c9bfa27c9a8e2b604b6c6b6cd966fab
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/kotorwidget.cpp

  Log Message:
  -----------
  KOTOR: Initialize KotORWidget::_unselected*

This fixes Coverity Scan issue #1383492.


  Commit: a760457a806796a2cdbe4fba71c3fe2533353905
      https://github.com/xoreos/xoreos/commit/a760457a806796a2cdbe4fba71c3fe2533353905
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/checkbox.h

  Log Message:
  -----------
  KOTOR: Minor style fix: move methods below variables


  Commit: 9a685b946de581c5b0c3cda662c3e46d661e0e60
      https://github.com/xoreos/xoreos/commit/9a685b946de581c5b0c3cda662c3e46d661e0e60
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/engines/kotor/gui/widgets/checkbox.cpp

  Log Message:
  -----------
  KOTOR: Initialize WidgetCheckBox::_unselected*


  Commit: 3939f89485f5f0cdca0e474e3ee9fef8b4a6046c
      https://github.com/xoreos/xoreos/commit/3939f89485f5f0cdca0e474e3ee9fef8b4a6046c
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/graphics/aurora/guiquad.cpp

  Log Message:
  -----------
  GRAPHICS: Initialize GUIQuad::_scissor*

This fixes Coverity Scan issue #1383497.


  Commit: 6f642e71ff11d9601ba1ac8d70c6785111c7c9da
      https://github.com/xoreos/xoreos/commit/6f642e71ff11d9601ba1ac8d70c6785111c7c9da
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/graphics/aurora/guiquad.cpp

  Log Message:
  -----------
  GRAPHICS: Initialize GUIQuad::_additiveBlending in all constructors

This fixes Coverity Scan issue #1383498.


  Commit: 7e5cbb259e017416b041ee4a4cd2cd5c5ddfe0e0
      https://github.com/xoreos/xoreos/commit/7e5cbb259e017416b041ee4a4cd2cd5c5ddfe0e0
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/graphics/aurora/subscenequad.cpp

  Log Message:
  -----------
  GRAPHICS: Initialize SubSceneQuad::_lastSampled

And behave currently on the very first sampling.
This fixes Coverty Scan issue #1383501.


  Commit: 272b60e33b37041c2f487c97614009a357ac6f78
      https://github.com/xoreos/xoreos/commit/272b60e33b37041c2f487c97614009a357ac6f78
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/graphics/aurora/subscenequad.cpp

  Log Message:
  -----------
  GRAPHICS: Fix minor style issue: std::vector<>::size() returns size_t


  Commit: 5c7fdbfc63e3e7b57f5f5d69b159c943de8fed84
      https://github.com/xoreos/xoreos/commit/5c7fdbfc63e3e7b57f5f5d69b159c943de8fed84
  Author: Sven Hesse <drmccoy at drmccoy.de>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/graphics/aurora/fadequad.cpp
    M src/graphics/aurora/fadequad.h

  Log Message:
  -----------
  GRAPHICS: Give FadeQuad a proper initial state

This fixes Coverity Scan issue #1383504.


Compare: https://github.com/xoreos/xoreos/compare/819ae3eeba2a...5c7fdbfc63e3