[xoreos-git] [DrMcCoy/xoreos] 3284f4: ALL: Warnings about inconsistent struct/class decl...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/DrMcCoy/xoreos
  Commit: 3284f44074835c43dc2d21025a51e73042289a58
      https://github.com/DrMcCoy/xoreos/commit/3284f44074835c43dc2d21025a51e73042289a58
  Author: Beren Minor <beren.minor+git at gmail.com>
  Date:   2013-05-31 (Fri, 31 May 2013)

  Changed paths:
    M src/aurora/nwscript/variable.h
    M src/common/maths.h

  Log Message:
  -----------
  ALL: Warnings about inconsistent struct/class declarations

Some types were forward-declared as class but are then declared as
struct. Clang complains about the inconsistency.


  Commit: c589b2b29eb19ad6df33c476bcd5bc7e5d04b88f
      https://github.com/DrMcCoy/xoreos/commit/c589b2b29eb19ad6df33c476bcd5bc7e5d04b88f
  Author: Beren Minor <beren.minor+git at gmail.com>
  Date:   2013-05-31 (Fri, 31 May 2013)

  Changed paths:
    M src/engines/kotor/kotor.h
    M src/engines/kotor2/kotor2.h
    M src/engines/nwn/door.h
    M src/engines/nwn/placeable.h

  Log Message:
  -----------
  ENGINES: Warnings about overloaded virtual methods hiding inherited ones

Clang complains about some overriding methods hiding inherited
overloaded versions. Defining the overloaded methods in the derived
classes as well solves the issue.

Anyway, this is not an ideal design, see: http://bit.ly/12Wje7V


  Commit: eecf58e79000dec4b61ac1c0b394f1e3310f62dd
      https://github.com/DrMcCoy/xoreos/commit/eecf58e79000dec4b61ac1c0b394f1e3310f62dd
  Author: Beren Minor <beren.minor+git at gmail.com>
  Date:   2013-05-31 (Fri, 31 May 2013)

  Changed paths:
    M src/video/bink.cpp

  Log Message:
  -----------
  VIDEO: Warnings about '< 0' check on unsigned variable

Wether the variable shouldn't be unsigned or the condition
is useless.


Compare: https://github.com/DrMcCoy/xoreos/compare/65f82aaeebe1...eecf58e79000