[xoreos-git] [xoreos/xoreos] 3b5c48: KOTOR: Fix usage of dynamic_cast<>()

GitHub noreply at github.com
Wed Jun 26 08:17:22 CEST 2013


  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: 3b5c484c55ce2abaec4b7b7ec2225070335b75be
      https://github.com/xoreos/xoreos/commit/3b5c484c55ce2abaec4b7b7ec2225070335b75be
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/kotor/gui/main/options.cpp

  Log Message:
  -----------
  KOTOR: Fix usage of dynamic_cast<>()

dynamic_cast<>() to a pointer may return 0, which has
to be checked for.
dynamic_cast<>() to a reference may throw an exception instead.

Coverity issue 1038265.


  Commit: 627a3d111c24c7e580479f0c284cb60008978ef8
      https://github.com/xoreos/xoreos/commit/627a3d111c24c7e580479f0c284cb60008978ef8
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/nwn/gui/widgets/listbox.cpp

  Log Message:
  -----------
  NWN: Fix format string type mismatch

Coverity issue 1038251.


  Commit: 3e61d1e6080e66d8e93463397ca83d30d121f6c7
      https://github.com/xoreos/xoreos/commit/3e61d1e6080e66d8e93463397ca83d30d121f6c7
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/nwn/creature.cpp

  Log Message:
  -----------
  NWN: Fix a leak in loadEquippedItems()

Coverity issue 1038250.


  Commit: 53a16a7b177d51289ee04eaf4bb077d486926948
      https://github.com/xoreos/xoreos/commit/53a16a7b177d51289ee04eaf4bb077d486926948
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/nwn/nwn.cpp

  Log Message:
  -----------
  NWN: Fix possible leak in mainMenuLoop()

Coverity issue 1038249.


  Commit: 0bb95cf40624979d3d50f825d63b18f69ddc360d
      https://github.com/xoreos/xoreos/commit/0bb95cf40624979d3d50f825d63b18f69ddc360d
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/nwn/gui/widgets/listbox.cpp

  Log Message:
  -----------
  NWN: Initialize _itemNumber

Coverity issue 1038217.


  Commit: e3d1dc93ac43f6110c45756813ef1b709c9c389f
      https://github.com/xoreos/xoreos/commit/e3d1dc93ac43f6110c45756813ef1b709c9c389f
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/images/txb.cpp

  Log Message:
  -----------
  GRAPHICS: Fix a leak in TXB::readHeader()

Coverity issue 1038248.


  Commit: db4f265cf10e2c6d1f3371929690a3a3141beaa5
      https://github.com/xoreos/xoreos/commit/db4f265cf10e2c6d1f3371929690a3a3141beaa5
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/indexbuffer.cpp

  Log Message:
  -----------
  GRAPHICS: Fix potential invalid free in the copy constructor

Coverity issue 1038205.


  Commit: f0344b76233c8506568e4ac1f894eb755c42ea16
      https://github.com/xoreos/xoreos/commit/f0344b76233c8506568e4ac1f894eb755c42ea16
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/vertexbuffer.cpp

  Log Message:
  -----------
  GRAPHICS: Fix potential invalid free in the copy constructor

Coverity issue 1038204.


  Commit: de8ba7f561e1d39090fa09628ef2be2bc8612532
      https://github.com/xoreos/xoreos/commit/de8ba7f561e1d39090fa09628ef2be2bc8612532
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/aurora/modelnode.h

  Log Message:
  -----------
  GRAPHICS: Make the ModelNode destructor virtual

Necessary, since we delete upcast ModelNode pointers.

Coverity issue 1038193.


  Commit: f05a3184c1991c2e1b3213def125324fd00f4bb2
      https://github.com/xoreos/xoreos/commit/f05a3184c1991c2e1b3213def125324fd00f4bb2
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/error.cpp

  Log Message:
  -----------
  COMMON: Catch exceptions thrown in printException()

Inception...

Coverity issue 1038238 and 1038240, again.


  Commit: 94766d7d0c408e76a725b029f41c5e30c58b01d4
      https://github.com/xoreos/xoreos/commit/94766d7d0c408e76a725b029f41c5e30c58b01d4
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/configman.cpp

  Log Message:
  -----------
  COMMON: Catch exceptions thrown in findGame()

Coverity issue 1038237.


Compare: https://github.com/xoreos/xoreos/compare/363ff413c8e4...94766d7d0c40


More information about the xoreos-git mailing list