[xoreos-git] [xoreos/xoreos] 6bd514: MAIN: Catch exceptions thrown by ConfigManager::sa...

Tue Jun 25 23:18:35 CEST 2013

  Branch: refs/heads/master
  Home:   https://github.com/xoreos/xoreos
  Commit: 6bd51477167d4880d97b8a60411d9303f421a1f0
      https://github.com/xoreos/xoreos/commit/6bd51477167d4880d97b8a60411d9303f421a1f0
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/xoreos.cpp

  Log Message:
  -----------
  MAIN: Catch exceptions thrown by ConfigManager::save()

Coverity issue 1038240.

  Commit: 438f912774a0c6e7d191e02405a6c3c9ebca3848
      https://github.com/xoreos/xoreos/commit/438f912774a0c6e7d191e02405a6c3c9ebca3848
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/debugman.cpp

  Log Message:
  -----------
  COMMON: Catch exceptions thrown by boost::posix_time::ptime

Coverity issue 1038239.

  Commit: 0cd6e4e6c89fc874e8894e8eee204c9c45b2929e
      https://github.com/xoreos/xoreos/commit/0cd6e4e6c89fc874e8894e8eee204c9c45b2929e
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/debugman.cpp

  Log Message:
  -----------
  COMMON: Catch exceptions thrown by UString::iterator::operator--()

Coverity issue 1038238.

  Commit: b0459fb09a5afbc98574d01f1723d4cd8219d943
      https://github.com/xoreos/xoreos/commit/b0459fb09a5afbc98574d01f1723d4cd8219d943
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/xoreos.cpp

  Log Message:
  -----------
  MAIN: Catch exceptions thrown by Common::FilePath::makeAbsolute()

Coverity issue 1038237.

  Commit: 1bfda47146de49422c345696195c2454395f8eed
      https://github.com/xoreos/xoreos/commit/1bfda47146de49422c345696195c2454395f8eed
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/stream.cpp
    M src/common/stream.h

  Log Message:
  -----------
  COMMON: Do not call ReadStream::eos in SubReadStream::read

cf. ScummVM commit c6112f738312ff6243b3fca1373d4d44ef08ee32:

Instead I moved the call to ReadStream::eos into SubReadStream::eos.

fuzzie pointed out that in certain cases this resulted in a lot of eos calls
before. Those were rather needlessly, since checking the eos bit of the
decorated stream in read does not give any advantage over checking it when
the client code really wants to test the eos flag.

  Commit: bdfb4d32164c5dd46c8242f884b734c8ed97f73c
      https://github.com/xoreos/xoreos/commit/bdfb4d32164c5dd46c8242f884b734c8ed97f73c
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/foxpro.cpp

  Log Message:
  -----------
  COMMON: Fix header flags reading

Coverity issues 1038268 and 1038266.

  Commit: 27ed939cfdb9145edad6edcbe010f5e187cbccc6
      https://github.com/xoreos/xoreos/commit/27ed939cfdb9145edad6edcbe010f5e187cbccc6
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/readline.cpp

  Log Message:
  -----------
  COMMON: Fix CTRL-K

Coverity issue 1038267.

  Commit: 6de9960f0b559a6e208690e8bde5c8a3826bde64
      https://github.com/xoreos/xoreos/commit/6de9960f0b559a6e208690e8bde5c8a3826bde64
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/configfile.cpp

  Log Message:
  -----------
  COMMON: Fix possible usage of invalid DomainList iterator

Coverity issue 1038262.

  Commit: 4e7d85f8b418636dd86e1ec6da4181e12c4eb910
      https://github.com/xoreos/xoreos/commit/4e7d85f8b418636dd86e1ec6da4181e12c4eb910
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/configfile.cpp

  Log Message:
  -----------
  COMMON: Fix possible usage of invalid LineList iterator

Coverity issue 1038261.

  Commit: 3dcd58703a10c04b842e008ad3b34997e0aba28e
      https://github.com/xoreos/xoreos/commit/3dcd58703a10c04b842e008ad3b34997e0aba28e
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/debugman.cpp
    M src/common/debugman.h

  Log Message:
  -----------
  COMMON: Fix possible out of bound reads in the debug channel

Coverity issues 1038257 and 1038258.

  Commit: 1ad93d3c0341109404194c623813a06224fd0b1f
      https://github.com/xoreos/xoreos/commit/1ad93d3c0341109404194c623813a06224fd0b1f
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/debugman.cpp

  Log Message:
  -----------
  COMMON: Initialize _logFileStartLine

Coverity issue 1038233.

  Commit: c38f2573325ccb84af3e18a97e3967e9c6285069
      https://github.com/xoreos/xoreos/commit/c38f2573325ccb84af3e18a97e3967e9c6285069
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/ustring.cpp

  Log Message:
  -----------
  COMMON: Initialize _size in the iterator'd constructor

Coverity issue 1038229.

  Commit: 5a96294940e304cd7f5e214a8280847a4e9eeed6
      https://github.com/xoreos/xoreos/commit/5a96294940e304cd7f5e214a8280847a4e9eeed6
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/common/file.cpp

  Log Message:
  -----------
  COMMON: Fix DumpFile::err()

Coverity issue 1038195.

  Commit: a74a7db25b1a05262ed8e8005f858d14bd0ad665
      https://github.com/xoreos/xoreos/commit/a74a7db25b1a05262ed8e8005f858d14bd0ad665
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/sound/decoders/wma.cpp

  Log Message:
  -----------
  SOUND: Fix possible out of bound reads in decodeExpHuffman()

Coverity issue 1038255.

  Commit: 2dd5bc3f2fcca2dda07e7f2f1e1d2a2836d59a67
      https://github.com/xoreos/xoreos/commit/2dd5bc3f2fcca2dda07e7f2f1e1d2a2836d59a67
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/sound/decoders/wma.cpp

  Log Message:
  -----------
  SOUND: Fix leak in decodeSuperFrame()

Coverity issue 1038247.

  Commit: 3d918abba0e4e31b53ae967128e716138824ba39
      https://github.com/xoreos/xoreos/commit/3d918abba0e4e31b53ae967128e716138824ba39
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/aurora/2dafile.cpp

  Log Message:
  -----------
  AURORA: Fix format string type mismatch

Coverity issue 1038252.

  Commit: f4a62b61f2fbc6a30e5a7a3b39a969f13bb2e8d0
      https://github.com/xoreos/xoreos/commit/f4a62b61f2fbc6a30e5a7a3b39a969f13bb2e8d0
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/kotor/gui/main/options.cpp

  Log Message:
  -----------
  KOTOR: Fix usage of dynamic_cast<>()

dynamic_cast<>() to a pointer may return 0, which has
to be checked for.
dynamic_cast<>() to a reference may throw an exception instead.

Coverity issue 1038265.

  Commit: a4675b4645a392746b6aef304cdc842d51fc82ac
      https://github.com/xoreos/xoreos/commit/a4675b4645a392746b6aef304cdc842d51fc82ac
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/kotor/gui/main/options.cpp
    M src/engines/nwn/gui/widgets/listbox.cpp

  Log Message:
  -----------
  NWN: Fix format string type mismatch

Coverity issue 1038251.

  Commit: 59dc9b3fc7f6233c7500fcdbd9ad7486783d4b99
      https://github.com/xoreos/xoreos/commit/59dc9b3fc7f6233c7500fcdbd9ad7486783d4b99
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/nwn/creature.cpp

  Log Message:
  -----------
  NWN: Fix a leak in loadEquippedItems()

Coverity issue 1038250.

  Commit: b62c38a2d0c55d76fc24220d2387b7adecca8705
      https://github.com/xoreos/xoreos/commit/b62c38a2d0c55d76fc24220d2387b7adecca8705
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/nwn/nwn.cpp

  Log Message:
  -----------
  NWN: Fix possible leak in mainMenuLoop()

Coverity issue 1038249.

  Commit: fc8e4a8875c63e7144cfb6e6608d7927b9f73179
      https://github.com/xoreos/xoreos/commit/fc8e4a8875c63e7144cfb6e6608d7927b9f73179
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/engines/nwn/gui/widgets/listbox.cpp

  Log Message:
  -----------
  NWN: Initialize _itemNumber

Coverity issue 1038217.

  Commit: 7f7f6733ee241b8c5072ab68e1d2f3c41455d082
      https://github.com/xoreos/xoreos/commit/7f7f6733ee241b8c5072ab68e1d2f3c41455d082
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/images/txb.cpp

  Log Message:
  -----------
  GRAPHICS: Fix a leak in TXB::readHeader()

Coverity issue 1038248.

  Commit: dffebf9475107d5e4b26832923b4b02eb7a976fb
      https://github.com/xoreos/xoreos/commit/dffebf9475107d5e4b26832923b4b02eb7a976fb
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/indexbuffer.cpp

  Log Message:
  -----------
  GRAPHICS: Fix potential invalid free in the copy constructor

Coverity issue 1038205.

  Commit: 239b9efc05dd772772918f1c3fd21f80e38af2a3
      https://github.com/xoreos/xoreos/commit/239b9efc05dd772772918f1c3fd21f80e38af2a3
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/vertexbuffer.cpp

  Log Message:
  -----------
  GRAPHICS: Fix potential invalid free in the copy constructor

Coverity issue 1038204.

  Commit: b9ef84f7de9c8baa665a46e4bcae2b2ec9affea5
      https://github.com/xoreos/xoreos/commit/b9ef84f7de9c8baa665a46e4bcae2b2ec9affea5
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-06-25 (Tue, 25 Jun 2013)

  Changed paths:
    M src/graphics/aurora/modelnode.h

  Log Message:
  -----------
  GRAPHICS: Make the ModelNode destructor virtual

Necessary, since we delete upcast ModelNode pointers.

Coverity issue 1038193.

Compare: https://github.com/xoreos/xoreos/compare/38e2ee20d140...b9ef84f7de9c