[xoreos-git] [DrMcCoy/xoreos] 3b5a40: SOUND: Add MP3 detection

GitHub noreply at github.com
Sat Jan 12 11:51:33 CET 2013


  Branch: refs/heads/master
  Home:   https://github.com/DrMcCoy/xoreos
  Commit: 3b5a402c1b0aa9004a008ac979778d0b4ebd2072
      https://github.com/DrMcCoy/xoreos/commit/3b5a402c1b0aa9004a008ac979778d0b4ebd2072
  Author: Sven Hesse <drmccoy at users.sourceforge.net>
  Date:   2013-01-12 (Sat, 12 Jan 2013)

  Changed paths:
    M src/sound/sound.cpp

  Log Message:
  -----------
  SOUND: Add MP3 detection

We determine that a stream is a MP3 stream if
a) We find an ID3v2 tag   or
b) We find a sane MPEG frame header

This is not fool proof, but should suffice for us.
Should false positives become a problem later one, we should
a) Calculate frame lengths and check next $n frames   and
b) Check the ID3v2 tag for sanity   and
c) Also check for sane frame headers when we found an ID3v2 tag





More information about the xoreos-git mailing list